Open
Conversation
Member
Author
|
We should also contact the pip people to see if parse_requirements can be moved to a library. |
Member
|
Good idea. At the moment, I question why CI complains and report errors on all tests |
70ffe4f to
fcb91df
Compare
fcb91df to
ae32588
Compare
Member
Author
|
Fixed the failures |
loechel
approved these changes
Apr 29, 2018
Member
Author
|
I will look into adding tests later this week |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for pip constraints files. I haven't added any tests yet, as I'm not sure you want to have it like this. It seems like you plan something like it for 2.0 though.