Fix Timer paused behavior test scope and ensure compilation#1
Open
Fix Timer paused behavior test scope and ensure compilation#1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refines and corrects the test coverage for the Timer class in the Godot Engine test suite.
Specifically, I adjusted the paused-timer runtime test to ensure it is properly scoped within a valid TEST_CASE block and compiles successfully. The updated test verifies that a paused timer does not emit the timeout signal when the scene tree is processed beyond its wait time.
During development, I rebuilt the engine locally with tests enabled and confirmed that all Timer test cases compile and pass successfully.