Conversation
Greptile SummaryThis PR adds a Confidence Score: 5/5Safe to merge; all remaining findings are P2 style/robustness suggestions that do not block functionality. No P0 or P1 issues found. The two P2 items in controller_hooks.go (swallowed os.Stat errors, duplicated mount-path constant) and the debug sleep in the sample file are minor quality improvements that don't affect correctness. pkg/agentrun-harness/controller/controller_hooks.go — minor error-handling and path-duplication concerns.
|
| Filename | Overview |
|---|---|
| internal/controller/agentrun_controller.go | Adds reconcileBootstrapConfigMap which creates a per-run ConfigMap from AgentRuntime.Spec.BootstrapScript and wires the owner ref to the pod; follows the existing secret reconciliation pattern correctly. |
| internal/controller/agentrun_pod.go | Adds enableBootstrapScript which mounts the bootstrap ConfigMap as an executable file into the default container; volume / VolumeMount wiring is correct. |
| pkg/agentrun-harness/controller/controller_hooks.go | Adds runBootstrapScript executed in preExecHook; has two minor issues: non-NotExist os.Stat errors are swallowed, and the mount path is duplicated from a separate package with no enforcement of synchrony. |
| config/samples/agentRuntime.yaml | Sample updated with a bootstrap script example, but contains a sleep 5 debug artefact that users may copy-paste. |
| api/v1alpha1/agentruntime_types.go | Adds optional BootstrapScript *string field to AgentRuntimeSpec with correct kubebuilder annotation. |
| api/v1alpha1/zz_generated.deepcopy.go | Auto-generated deep copy for the new BootstrapScript pointer field; correct. |
| charts/deployment-operator/crds/deployments.plural.sh_agentruntimes.yaml | CRD schema updated with the new optional bootstrapScript string field; matches the type definition. |
| config/crd/bases/deployments.plural.sh_agentruntimes.yaml | Identical CRD update in the config bases directory; consistent with the charts CRD. |
Reviews (1): Last reviewed commit: "add AgentRuntime setup script" | Re-trigger Greptile
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Add support for bash script that will be executed inside the cloned repository directory before the coding agent starts
Test Plan
Test environment: https://console.your-env.onplural.sh/
Checklist