fix: Combining lua folder and string should have line breaks#732
fix: Combining lua folder and string should have line breaks#732michaeljguarino merged 1 commit intomainfrom
Conversation
Causes syntax errors if last file doesn't end in newline
Greptile SummaryThis PR fixes a Lua syntax error that could occur when combining files from a Lua folder with an additional Lua script/file. The " "` at that join point, matching the existing inter-file separator pattern. Confidence Score: 5/5Safe to merge — single-line fix that correctly resolves the Lua concatenation issue. The change is a minimal, well-scoped fix that mirrors the existing " " separator already used inside luaFolder itself. No logic is altered beyond the join point, and trailing " " when luaString is empty is harmless to the Lua runtime. No P0/P1 findings. No files require special attention.
|
| Filename | Overview |
|---|---|
| pkg/manifests/template/helm.go | Adds "\n\n" separator between luaFolder content and luaString to prevent Lua syntax errors when the last folder file lacks a trailing newline. |
Reviews (1): Last reviewed commit: "fix: Combining lua folder and string sho..." | Re-trigger Greptile
Causes syntax errors if last file doesn't end in newline
Test Plan
Test environment: https://console.plrldemo.onplural.sh/cd/clusters/31c95d8f-983c-435a-8985-bd1327f4334a/services/5486a614-6793-474d-92d6-4a338d10eace/components
Checklist