fix(guard): scrub denied keys from search results (I14) - #4
Merged
Conversation
search_filtered now runs the same linked_keys/disclosable/scrub_links pass as issue_info, so issuelinks/parent/subtasks on served search results cannot name policy-denied keys (I14). Assessment fan-out is bounded by MAX_ASSESS_KEYS; keys past the bound or with failed fetches scrub fail-closed (I4). Scrubbed keys surface only in the audit stream, never as counts or keys to the client (I3).
plusky
added
security
plusky
enabled auto-merge (rebase)
August 8, 2026 19:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
search_filteredrequestedissuelinks,parent,subtasks(they ride along inCLASSIFY_FIELDS) and returned Read-granted issues verbatim, so a denied issue's key could reach the client inside a visible search hit — exactly the fields I14 names.issue_infoandissue_historyalready scrubbed; search did not.The search path now runs the same
linked_keys/disclosable/scrub_linksmachinery asissue_info, bounded by the existingMAX_ASSESS_KEYSmechanics: candidate keys past the bound or whose classification fetch fails are scrubbed, not served.Invariants: I14 (denied keys no longer appear in served link fields on the search path), I3 (no scrubbed/dropped counts surface to the client; audit only), I4 (undecidable candidates scrub).
Tests: new wiremock coverage exercising
search_filteredend-to-end (issues_search returnswindow.issuesverbatim, so this pins the client-visible surface); confirmed to fail against the unfixed code.Process: AI-assisted — implemented and independently adversarially reviewed against
docs/DESIGN.md(verdict: approve, with an empirical pre-fix-failure check). Full verification suite green at the commit.