Align schema definitions and READMEs with actual Java code#31
Conversation
- Updated H2, PostgreSQL, and Oracle create table scripts to use BIGINT (or NUMBER(19)) for EXPIRE_SEC to align with the Java API's `long expirationSeconds`.
- Updated H2 and Oracle scripts to use TIMESTAMP instead of DATETIME for consistency.
- Updated main README.md SQL example to use TIMESTAMP and BIGINT.
- Updated dlock-api/README.md to exactly match the Javadocs in KeyLock.java, including `{@value}` references and updated tags.
Co-authored-by: pmalirz <19637300+pmalirz@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This commit aligns the database schema definitions (both the actual setup scripts and the documentation examples) with the underlying Java code.
Specifically, the Java API uses a
longforexpirationSeconds, but the SQL schema scripts and documentation usedint(orINTEGER). These have been corrected toBIGINT(andNUMBER(19)for Oracle) to prevent potential truncation or mismatch errors at the JDBC boundary.Additionally,
DATETIMEwas changed toTIMESTAMPin H2 and Oracle scripts for better consistency across supported databases.The API README was also synced with the actual Javadoc tags found in
KeyLock.java, fixing the documentation-to-code drift.PR created automatically by Jules for task 4587391659440173615 started by @pmalirz