Skip to content

refactor: bias module mostly switched to subgroup analysis class + ex…#33

Draft
JoshuaSiraj wants to merge 2 commits into
mainfrom
JoshuaSiraj/bias/survival_refactor
Draft

refactor: bias module mostly switched to subgroup analysis class + ex…#33
JoshuaSiraj wants to merge 2 commits into
mainfrom
JoshuaSiraj/bias/survival_refactor

Conversation

@JoshuaSiraj

Copy link
Copy Markdown
Collaborator

…ample usage

@JoshuaSiraj JoshuaSiraj marked this pull request as draft February 11, 2025 19:08
@JoshuaSiraj JoshuaSiraj requested a review from skim2257 February 11, 2025 19:54

@skim2257 skim2257 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review

Comment thread bruh.py

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this meant to be in main?

Comment thread src/jarvais/utils/plot.py

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does show_figure cause the pipeline to pause until the window is dismissed if it's run as a script? I understand in notebook it would just display and move along, but I'm wondering how it would behave as a standalone Python script

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo: switch default to false


from ..utils.plot import plot_kaplan_meier_by_category

def generate_violin(

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

send to utils.plot

@JoshuaSiraj JoshuaSiraj force-pushed the JoshuaSiraj/bias/survival_refactor branch from cb47578 to aa951da Compare July 30, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants