Skip to content

fix: suggestion rendering at cursor position with green underline #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pmqueiroz merged 1 commit into from
May 13, 2026
Merged

fix: suggestion rendering at cursor position with green underline #66

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 27 additions & 19 deletions src/ui/components/term.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,34 @@ fn row_spans(
font_size,
));
}
let ch = if cell.c == ' ' { '_' } else { cell.c };
let cursor_color = theme::color::runtime().cursor;
if let Some(sugg) = suggestion {
let max_chars = row_cells.len().saturating_sub(x);
let display: String = sugg.chars().take(max_chars).collect();
if let Some(first) = display.chars().next() {
spans.push(
Span::new(first.to_string())
.color(cursor_color)
.underline(true)
.font(theme::font::REGULAR)
.size(font_size),
);
let rest: String = display.chars().skip(1).collect();
if !rest.is_empty() {
let rt = theme::color::runtime();
let mut dim_color = rt.foreground;
dim_color.a = 0.35;
spans.push(
Span::new(rest)
.color(dim_color)
.font(theme::font::REGULAR)
.size(font_size),
);
}
}
break;
}
let ch = if cell.c == ' ' { '_' } else { cell.c };
spans.push(
Span::new(ch.to_string())
.color(cursor_color)
Expand Down Expand Up @@ -153,24 +179,6 @@ fn row_spans(
spans.push(cell_span(seg_text, seg_fg, seg_bg, seg_attrs, font_size));
}

if let Some(sugg) = suggestion
&& !sugg.is_empty()
{
let chars_remaining = row_cells.len().saturating_sub(cursor_col.unwrap_or(0) + 1);
let display: String = sugg.chars().take(chars_remaining).collect();
if !display.is_empty() {
let rt = crate::ui::theme::color::runtime();
let mut dim_color = rt.foreground;
dim_color.a = 0.35;
spans.push(
Span::new(display)
.color(dim_color)
.font(theme::font::REGULAR)
.size(font_size),
);
}
}

spans
}

Expand Down