feat: implement split pane with active indicator and pane management#71
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds split-pane support to Nova’s terminal UI, including an active-pane indicator, pane-close controls, and grid/PTY management so two terminals can run side-by-side within a single tab.
Changes:
- Introduces a
SplitPanemodel onTaband tracks which pane is active for input routing. - Updates the terminal renderer and main view layout to display two panes with an active indicator and close buttons.
- Extends resize, PTY subscription, PTY ready/exit handling, and input/output plumbing to support a second PTY/grid.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| src/ui/tab.rs | Adds SplitPane struct and split-pane state to Tab. |
| src/ui/components/term.rs | Refactors terminal widget to render from a Grid directly (usable for both panes). |
| src/ui/app_state/view.rs | Renders split layout with active indicator and close buttons. |
| src/ui/app_state/update/window.rs | Resizes both pane grids and sends PTY resize commands in split mode. |
| src/ui/app_state/update/tabs.rs | Adds split-pane creation and close/promote-left-pane handling. |
| src/ui/app_state/update/mouse.rs | Tracks active pane on click (split vs primary). |
| src/ui/app_state/update/mod.rs | Wires new split-related messages and routes PTY ready/exit to split panes. |
| src/ui/app_state/update/input.rs | Routes input/output for split PTY and maintains split grid state. |
| src/ui/app_state/subscription.rs | Starts a second PTY worker subscription for split panes. |
| src/ui/app_state/message.rs | Adds messages for split/open/close actions. |
| src/ui/app_state/helpers.rs | Adds calc_grid_split for sizing split-pane grids. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.