Feature/hashicorp gradle kotlin enhancements#9
Open
ethaden wants to merge 3 commits intopneff93:mainfrom
Open
Conversation
ethaden
force-pushed
the
feature/hashicorp_gradle_kotlin_enhancements
branch
from
f66e985 to
7b7c8d9
Compare
pneff93
reviewed
Jan 24, 2024
Owner
There was a problem hiding this comment.
The template should be in the HashiCorp folder, not in the root one
pneff93
reviewed
Jan 24, 2024
|
|
||
| We register the schema with setting `PII` to the birthday field and defining the encryption rule | ||
| We register the schema with setting `PII` to the birthday field and defining the encryption rule. | ||
| First, get the REST endpoint for your Confluent cluster from the Web UI and set it to a variable. Set another value to the topic name you use in `client.properties`: |
Owner
There was a problem hiding this comment.
Could you please describe the strategy of using the client.properties a bit more in detail?
Also, I guess the next shell part is not scraped from the client.properties directly but needs to be exported manually?
pneff93
requested changes
Jan 24, 2024
Owner
pneff93
left a comment
pneff93
left a comment
There was a problem hiding this comment.
Only minor things
Once fixed, I will merge it and test it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated gradle version and enhanced the kotlin implementation by removing the need to have hard-coded credentials in the code