Revokes a Viva Engage role from a user. Closes #6821#7077
Open
Revokes a Viva Engage role from a user. Closes #6821#7077
Conversation
f6d16c4 to
c7d1b90
Compare
There was a problem hiding this comment.
Pull request overview
This PR implements a new CLI command viva engage role member remove that allows removing (revoking) a user from a Viva Engage role through the Microsoft Graph API. The command supports identifying roles and users by either ID or name, includes confirmation prompts, and follows the established patterns for similar remove commands in the codebase.
Changes:
- Adds a new command to remove users from Viva Engage roles with support for role/user identification by ID or name
- Includes comprehensive test coverage with validation, success, and error scenarios
- Adds complete documentation with examples, permissions, and usage information
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| src/m365/viva/commands/engage/engage-role-member-remove.ts | Implements the core command logic for removing users from Viva Engage roles |
| src/m365/viva/commands/engage/engage-role-member-remove.spec.ts | Provides comprehensive test coverage including validation, execution, and error handling tests |
| src/m365/viva/commands.ts | Registers the new command constant ENGAGE_ROLE_MEMBER_REMOVE |
| docs/docs/cmd/viva/engage/engage-role-member-remove.mdx | Documents the command with usage, options, examples, and permissions |
| docs/src/config/sidebars.ts | Adds navigation entry for the new command documentation |
| npm-shrinkwrap.json | Automatic dependency lockfile updates adding peer dependency flags |
Files not reviewed (1)
- npm-shrinkwrap.json: Language not supported
Jwaegebaert
requested changes
Feb 23, 2026
Contributor
Jwaegebaert
left a comment
There was a problem hiding this comment.
Nice work @MartinM85. There are a few minor changes I would suggest here. First of all, Copilot left a few interesting topics you could take a look at. I already resolved the topics that aren't relevant.
c7d1b90 to
3554423
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6821