Skip to content

Revokes a Viva Engage role from a user. Closes #6821#7077

Open
MartinM85 wants to merge 3 commits intopnp:mainfrom
MartinM85:feature/6821-viva-engage-role-member-remove
Open

Revokes a Viva Engage role from a user. Closes #6821#7077
MartinM85 wants to merge 3 commits intopnp:mainfrom
MartinM85:feature/6821-viva-engage-role-member-remove

Conversation

@MartinM85
Copy link
Contributor

Closes #6821

@MartinM85 MartinM85 force-pushed the feature/6821-viva-engage-role-member-remove branch from f6d16c4 to c7d1b90 Compare December 22, 2025 09:24
@Jwaegebaert Jwaegebaert requested a review from Copilot February 23, 2026 17:12
@Jwaegebaert Jwaegebaert self-assigned this Feb 23, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements a new CLI command viva engage role member remove that allows removing (revoking) a user from a Viva Engage role through the Microsoft Graph API. The command supports identifying roles and users by either ID or name, includes confirmation prompts, and follows the established patterns for similar remove commands in the codebase.

Changes:

  • Adds a new command to remove users from Viva Engage roles with support for role/user identification by ID or name
  • Includes comprehensive test coverage with validation, success, and error scenarios
  • Adds complete documentation with examples, permissions, and usage information

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 11 comments.

Show a summary per file
File Description
src/m365/viva/commands/engage/engage-role-member-remove.ts Implements the core command logic for removing users from Viva Engage roles
src/m365/viva/commands/engage/engage-role-member-remove.spec.ts Provides comprehensive test coverage including validation, execution, and error handling tests
src/m365/viva/commands.ts Registers the new command constant ENGAGE_ROLE_MEMBER_REMOVE
docs/docs/cmd/viva/engage/engage-role-member-remove.mdx Documents the command with usage, options, examples, and permissions
docs/src/config/sidebars.ts Adds navigation entry for the new command documentation
npm-shrinkwrap.json Automatic dependency lockfile updates adding peer dependency flags
Files not reviewed (1)
  • npm-shrinkwrap.json: Language not supported

Copy link
Contributor

@Jwaegebaert Jwaegebaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @MartinM85. There are a few minor changes I would suggest here. First of all, Copilot left a few interesting topics you could take a look at. I already resolved the topics that aren't relevant.

@MartinM85 MartinM85 force-pushed the feature/6821-viva-engage-role-member-remove branch from c7d1b90 to 3554423 Compare February 26, 2026 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New command: viva engage role member remove

3 participants