Let 'spo storageentity' reference tenant app catalog#7148
Open
MathijsVerbeeck wants to merge 2 commits intopnp:mainfrom
Open
Let 'spo storageentity' reference tenant app catalog#7148MathijsVerbeeck wants to merge 2 commits intopnp:mainfrom
MathijsVerbeeck wants to merge 2 commits intopnp:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the SharePoint Online spo storageentity command set so appCatalogUrl is no longer required and the commands default to using the tenant app catalog when it’s not provided, improving usability and aligning with issue #7128.
Changes:
- Make
--appCatalogUrloptional acrossset,remove, andlist, and add it toget, defaulting to the tenant app catalog when omitted. - Migrate these commands to Zod-based option schemas (
schemagetter + exportedoptions). - Update and extend unit tests and command docs to reflect the new defaulting behavior and validation.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/m365/spo/commands/storageentity/storageentity-set.ts | Makes appCatalogUrl optional, defaults to tenant app catalog, migrates options to Zod schema. |
| src/m365/spo/commands/storageentity/storageentity-set.spec.ts | Updates tests to parse options via schema; adds coverage for tenant app catalog default and not-found error. |
| src/m365/spo/commands/storageentity/storageentity-remove.ts | Makes appCatalogUrl optional with tenant app catalog fallback; migrates options to Zod schema. |
| src/m365/spo/commands/storageentity/storageentity-remove.spec.ts | Updates tests to schema parsing; adds tenant app catalog default/not-found scenarios. |
| src/m365/spo/commands/storageentity/storageentity-list.ts | Makes appCatalogUrl optional with tenant app catalog fallback; migrates options to Zod schema; returns [] when none found. |
| src/m365/spo/commands/storageentity/storageentity-list.spec.ts | Updates tests for schema parsing and new default behavior; asserts empty-array output. |
| src/m365/spo/commands/storageentity/storageentity-get.ts | Adds optional appCatalogUrl and defaults to tenant app catalog; migrates options to Zod schema. |
| src/m365/spo/commands/storageentity/storageentity-get.spec.ts | Updates tests for schema parsing; adds tenant app catalog default/not-found coverage. |
| docs/docs/cmd/spo/storageentity/storageentity-set.mdx | Marks appCatalogUrl optional and documents tenant app catalog default + updated examples. |
| docs/docs/cmd/spo/storageentity/storageentity-remove.mdx | Marks appCatalogUrl optional and documents tenant app catalog default + updated examples. |
| docs/docs/cmd/spo/storageentity/storageentity-list.mdx | Marks appCatalogUrl optional and documents tenant app catalog default + adds example without -u. |
| docs/docs/cmd/spo/storageentity/storageentity-get.mdx | Documents new optional appCatalogUrl behavior and adds an example targeting a specific app catalog. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7128
@milanholemans I noticed that for the setting and deleting of properties custom script has to be enabled on the site. I was wondering if we should add a remark for this?