fix: migrate up-check from Puppeteer to Playwright#39
fix: migrate up-check from Puppeteer to Playwright#39adrianschmidt-bot wants to merge 2 commits intodevfrom
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe pull request migrates website checking automation from Puppeteer to Playwright. Changes include updating the browser automation library in the workflow script, refactoring from IIFE to top-level async/await, and modifying the GitHub Actions workflow configuration to install Playwright dependencies instead of Puppeteer. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
194d2f7 to
777a9cd
Compare
The v2 migration added "type": "module" to package.json, which broke the CommonJS check script. Instead of working around it, migrate to Playwright which is already a project dependency. - Replace Puppeteer with Playwright in the check script - Use the shared set-up-node action and npm ci instead of ad-hoc install - Install only the chromium browser needed for the check
777a9cd to
f0a0046
Compare
| run: npm ci | ||
|
|
||
| - name: Install Playwright browser | ||
| run: npx playwright install --with-deps chromium |
There was a problem hiding this comment.
We probably want to cache this, right?
|
Good call! Added caching for the Playwright browser binaries ( |
The v2 migration added
"type": "module"to package.json, which broke the CommonJS check script (ReferenceError: require is not defined in ES module scope).Instead of working around it, this migrates to Playwright which is already a project dependency.
Changes:
npm ciinstead of ad-hoc Puppeteer installSummary by CodeRabbit