fix: prevent static IP assignment matching subnet gateway#894
Open
kavirakesh14 wants to merge 1 commit into
Open
fix: prevent static IP assignment matching subnet gateway#894kavirakesh14 wants to merge 1 commit into
kavirakesh14 wants to merge 1 commit into
Conversation
This adds validation in Netavark IPAM to mimic Docker's behavior, throwing an 'address already in use' error if a user requests a static IP that is already assigned to the subnet's gateway, preventing silent internal socket connection failures. Committer: kavirakesh14 <kavirakesh007@gmail.com> Signed-off-by: kavirakesh14 <kavirakesh007@gmail.com>
kavirakesh14
force-pushed
the
fix/netavark-gateway-conflict
branch
from
52e8967 to
9b9daa7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds a validation step to the Netavark IPAM logic to immediately reject static IP requests that conflict with the subnet's gateway IP.
Previously, if a container was started with a static IP matching the gateway, Netavark would accept it. The container would start successfully but suffer from silent internal networking failures, specifically resulting in "connection refused" errors on internal sockets.
By failing fast inside
allocIPswith an "address already in use" error, Podman's behavior now mirrors Docker's standard behavior and prevents this ghost networking state.Fixes Issue
Fixes podman-container-tools/podman#28863
How was this tested?
containers/commonlocally and linked it to a fresh build of Podman.go fmt,go vet, andgo test.