Conversation
ogabrielides
approved these changes
Mar 19, 2026
protocol/script/UpgradeBridge.s.sol
Outdated
| import {ITransparentUpgradeableProxy} from "@openzeppelin/contracts/proxy/transparent/TransparentUpgradeableProxy.sol"; | ||
|
|
||
| contract UpgradeBridge is Script { | ||
| /// @dev ERC-1967 admin slot: bytes32(uint256(keccak256("eip1967.proxy.admin")) - 1) |
Collaborator
There was a problem hiding this comment.
I just don't understand why . Could you explain why?
Suggested change
| /// @dev ERC-1967 admin slot: bytes32(uint256(keccak256("eip1967.proxy.admin")) - 1) | |
| /// @dev ERC-1967 admin slot: bytes32(uint256(keccak256("eip1967.proxy.admin")) - 1) |
Contributor
Author
There was a problem hiding this comment.
The upgradable proxy stores the address in specific storage slot and that's how the address of the slot is calculated. I changed that to use a constant from openzeppeling ERC1967.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Script to upgrade bridge proxy to new implementation