Conversation
Contributor
chunho
commented
Dec 2, 2025
chunho
commented
- Rename CustomToolCallDefinition to CustomCallDefinition for brevity and consistency
- Make description and format_ fields optional in CustomToolDefinition
- Update all tests to reflect the renaming and optional field changes
- Add tests for optional fields and partial initialization
…omToolDefinition fields optional - Rename CustomToolCallDefinition to CustomCallDefinition for brevity - Make description and format_ fields optional in CustomToolDefinition - Update all tests to reflect the renaming and optional field changes - Add tests for optional fields and partial initialization - Use Optional[] syntax for Python 3.9 compatibility
Reviewers: Test Plan: Differential Revision: Asana Tasks: Screenshot: CC: Deploy To:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.