Split out _upload_file method on PoeBot#206
Merged
agamble-quora merged 1 commit intopoe-platform:mainfrom Jan 21, 2026
Merged
Conversation
| inline_ref=inline_ref, | ||
| ) | ||
|
|
||
| async def _upload_file( |
Contributor
There was a problem hiding this comment.
Does this need to be _upload_file? Marking it like that / private does not seem like it's intended to be overridden by a subclass.
Or would having self.upload_file and upload_file be too confusing?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits out an
_upload_filemethod onPoeBotto allow customization via subclassing.