Expected failure for permission error deleting root shared record.#385
Open
Expected failure for permission error deleting root shared record.#385
Conversation
This reverts commit 6744fb7.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Something came up in Slack that shows we are enforcing permission settings even when deleting the root shared record. Ideally we would allow deleting the root record because that would just translate to removing yourself from the share, but instead we get an error when the delete cascades to child records.
I don't have a fix yet, but wanted to get a test failure in place (wrapped in
withKnownIssue) so that we can investigate later.