-
Notifications
You must be signed in to change notification settings - Fork 79
Fixes to date synchronization. #387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
6a9bab1
Fixes to date synchronization.
mbrandonw 9f10711
add test for bad representation
mbrandonw 3c2cac2
back out of pending changes stuff
mbrandonw 20cb21d
Merge remote-tracking branch 'origin/main' into fix-date-sync
mbrandonw f2af296
clean up
mbrandonw 1cdc2d6
wip
mbrandonw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| import DependenciesTestSupport | ||
| import Foundation | ||
| import SQLiteData | ||
| import SQLiteDataTestSupport | ||
| import Testing | ||
|
|
||
| @Suite(.dependency(\.defaultDatabase, try .database())) | ||
| struct DateTests { | ||
| @Dependency(\.defaultDatabase) var database | ||
|
|
||
| @Test func roundtrip() throws { | ||
| let date = Date(timeIntervalSinceReferenceDate: 793109282.061) | ||
| let insertedRecord = try database.write { db in | ||
| try Record.insert { Record.Draft(date: date) } | ||
| .returning(\.self) | ||
| .fetchOne(db)! | ||
| } | ||
| let updatedRecord = try database.write { db in | ||
| try Record | ||
| .update(insertedRecord) | ||
| .returning(\.self) | ||
| .fetchOne(db)! | ||
| } | ||
| #expect(insertedRecord.date == date) | ||
| #expect(insertedRecord.date == updatedRecord.date) | ||
| } | ||
| } | ||
|
|
||
| @Table | ||
| private struct Record: Equatable { | ||
| let id: Int | ||
| var date: Date | ||
| } | ||
|
|
||
| extension DatabaseWriter where Self == DatabaseQueue { | ||
| fileprivate static func database() throws -> DatabaseQueue { | ||
| let database = try DatabaseQueue() | ||
| try database.write { db in | ||
| try #sql( | ||
| """ | ||
| CREATE TABLE "records" ( | ||
| "id" INTEGER PRIMARY KEY AUTOINCREMENT, | ||
| "date" TEXT NOT NULL | ||
| ) STRICT | ||
| """ | ||
| ) | ||
| .execute(db) | ||
| } | ||
| return database | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the actual fix for the date issue.