Contains MiniWallet Contracts refactor, MiniServer, Proxy Upgrade Deploys and NFT Scaffolding#11
Closed
johnwhitton wants to merge 1 commit intoproxyUpgradefrom
Closed
Contains MiniWallet Contracts refactor, MiniServer, Proxy Upgrade Deploys and NFT Scaffolding#11johnwhitton wants to merge 1 commit intoproxyUpgradefrom
johnwhitton wants to merge 1 commit intoproxyUpgradefrom
Conversation
johnwhitton
changed the title
polymorpher
reviewed
Sep 2, 2022
polymorpher
reviewed
Sep 2, 2022
polymorpher
reviewed
Sep 2, 2022
polymorpher
reviewed
Sep 2, 2022
polymorpher
reviewed
Sep 2, 2022
polymorpher
reviewed
Sep 2, 2022
polymorpher
reviewed
Sep 2, 2022
polymorpher
reviewed
Sep 2, 2022
| emit SetBaseUri(baseUri); | ||
| } | ||
|
|
||
| function mintForCommunity(address _to, uint256 _numberOfTokens) |
Owner
There was a problem hiding this comment.
Let's have a batch version of this, or have a separate multi-call contract. I recall it wasn't a nice experience using this for thousands of airdrops
polymorpher
reviewed
Sep 2, 2022
polymorpher
reviewed
Sep 2, 2022
polymorpher
reviewed
Sep 2, 2022
polymorpher
reviewed
Sep 2, 2022
polymorpher
reviewed
Sep 2, 2022
polymorpher
reviewed
Sep 2, 2022
polymorpher
reviewed
Sep 2, 2022
polymorpher
reviewed
Sep 2, 2022
polymorpher
reviewed
Sep 3, 2022
polymorpher
reviewed
Sep 3, 2022
polymorpher
reviewed
Sep 3, 2022
Owner
polymorpher
left a comment
polymorpher
left a comment
There was a problem hiding this comment.
overall looks good aside from minor cosmetic and syntactical changes
Collaborator
Author
|
Outstanding Items
|
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch is being used to work on Minting NFT for users when registering #10