ws-miniwallet-v0 MiniWallet Functionality#16
Merged
polymorpher merged 40 commits intomainfrom Sep 19, 2022
Merged
Conversation
…eedback from PR 7
johnwhitton
changed the title
polymorpher
reviewed
Sep 18, 2022
| /** | ||
| * @dev Returns the current implementation address. | ||
| */ | ||
| function _implementation() |
Owner
There was a problem hiding this comment.
shouldn't be internal or starting with underscore
polymorpher
approved these changes
Sep 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MiniWallet Functionality MiniWallet Contract and MiniServer
Note all commits up to 7f3c01b have been reviewed under miniV0