Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ci.yml
permissions: {}jobs.lint.permissions.contents: readjobs.lint.name: Lintconcurrencyblock (group: ${{ github.workflow }}-${{ github.ref }},cancel-in-progress: true)actions/checkout@v5to93cb6efe18208431cddfb8368fd83d5badbf9bfdpnpm/action-setup@v4tofc06bc1257f339d1d5d8b3a19a8cae5388b55320actions/setup-node@v6to53b83947a5a98c8d113130e565377fae1a50d02fpersist-credentials: falseto theactions/checkoutsteprelease.yml
permissions: {}releasejob receives the explicitly listed scopes.jobs.release.permissions(id-token: write # for npm provenance,pull-requests: write # for changesets to create PRs,contents: write # for changesets to create releases)jobs.release.name: Releaseconcurrencyblock (group: ${{ github.workflow }}-${{ github.ref }},cancel-in-progress: true)main, avoiding race conditions in changesets PR creation or duplicate npm publishes.actions/checkout@v5to93cb6efe18208431cddfb8368fd83d5badbf9bfdpnpm/action-setup@v4tofc06bc1257f339d1d5d8b3a19a8cae5388b55320actions/setup-node@v6to53b83947a5a98c8d113130e565377fae1a50d02fchangesets/action@v1to6a0a831ff30acef54f2c6aa1cbbc1096b066edaf(v1.7.0)@v1tag floats across all v1.x releases; pinning to the exact commit eliminates that ambiguity.persist-credentials: falseto theactions/checkoutstepcontents: write— a leaked token could push arbitrary commits tomain.${{ secrets.SLACK_WEBHOOK_URL }}from inlinerun:interpolation to anenv:block, referenced as"$SLACK_WEBHOOK_URL"in the script${{ }}form expanded the secret directly into the shell script source before bash parsed itcurlargument and execute arbitrary shell commands.env:approach passes the value through an environment variable, which bash treats as data, not code.