UI comm: handle inputBoundaries RPC for Positron Quarto#1272
UI comm: handle inputBoundaries RPC for Positron Quarto#1272metehankaygsz wants to merge 1 commit into
Conversation
|
Input boundaries are meant to be provided by the LSP, not by the UI comm (we plan to split the LSP and kernel in the future). But I see that you do call the LSP in the Positron-side PR to get input boundaries, which seems right. Your Positron-side PR already works without this backend-side one, right? |
|
Yes, you’re right. I verified that the Positron-side PR already works without this change. I opened this PR because I misunderstood an earlier review comment asking for the accompanying Ark implementation and assumed the UI comm RPC still needed a backend handler. I now understand that the required Ark implementation already exists in the LSP and that adding it to UI comm would duplicate the functionality in the wrong architectural layer. Thanks for clarifying and for the references to #522 and #533. I’ll close this PR as unnecessary. |
Summary
callMethod("inputBoundaries", code)directly in the UI comm backendanalysis::input_boundariesparser logic{ boundaries: [...] }payload shape expected by PositronWhy
Positron Quarto now asks the R backend for all statement boundaries in a single request so it can split multi-expression inline chunks without paying for one completeness probe per line.
Testing
cargo test -p ark test_input_boundaries_call_method -- --nocaptureNotes
posit-dev/positron#14185