[DNM] fix: tri-state push compatibility for shared workflows#118
Draft
ianpittwood wants to merge 3 commits into
Draft
[DNM] fix: tri-state push compatibility for shared workflows#118ianpittwood wants to merge 3 commits into
ianpittwood wants to merge 3 commits into
Conversation
- bakery.yaml: add Standard (std, primary) and Minimal (min) variants
to workbench-session, mirroring workbench. Existing tags without a
variant suffix continue to resolve to std.
- workbench-session/template: conditionally COPY and install optional
packages on the std variant only, assert in goss on Standard only,
document the new tag format and variants in the README.
- workbench std + workbench-session std optional package lists:
expand to a curated dev-header + tooling set covering the most-
downloaded CRAN packages and common Python source-build paths.
Templates are grouped with Jinja {# ... -#} annotations explaining
each group; rendered .txt files stay annotation-free until
posit-dev/images-shared#550 lands.
Rationale, exclusion list, and tag examples are documented in the
PR description.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The shared bakery-build-native.yml push input is changing from boolean to a tri-state string (off/temp/on). Emit 'on'/'off' so callers stay valid. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Points the bakery-build reusable workflow refs at the images-shared feat/dry-run-artifacts branch so this PR's CI exercises the new tri-state push + temp-artifact behavior end-to-end. REVERT THIS COMMIT before merging — on main these must reference @main. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
posit-dev/images-shared#559 changes the reusable
bakery-build-native.ymlpushinput from a boolean to a tri-state string (off/temp/on). This repo'sproduction/development/content/sessionworkflows pass a booleanpush:expression, which the new input's validation guard would reject (expected off, temp, or on).This PR wraps each
push:expression so it emits the string'on'/'off'instead oftrue/false, preserving the exact prior behavior (push to final registries on main-push / schedule / dispatch-to-main; otherwise no push).Notes
'on'⇔ oldtrue,'off'⇔ oldfalse.pr.yml→bakery-build-pr.yml, which images-shared#559 separately enhances to publish temp debug artifacts for same-repo PRs.@main. CI on this branch will not be representative until #559 is merged. Merge #559 first (or together).Part of: posit-dev/images-shared#559
🤖 Generated with Claude Code