[POA-155] Changes for capturing client and server timeouts - #201
Open
shreys7 wants to merge 6 commits into
Open
Conversation
mgritter
approved these changes
Nov 2, 2023
mgritter
left a comment
mgritter
left a comment
Contributor
There was a problem hiding this comment.
Looks correct, good to go once akita-ir changes land and the generator is re-run on that version.
shreys7
changed the title
mgritter
approved these changes
Nov 10, 2023
…etadata of the parser
…o client and server shutdown metadata
mgritter
approved these changes
Nov 15, 2023
Comment on lines
+17
to
+23
| const ( | ||
| CONNECTION_TYPE_HTTP_CLIENT = "HTTP_CLIENT" | ||
| CONNECTION_TYPE_HTTP_SERVER = "HTTP_SERVER" | ||
| CONNECTION_TYPE_TLS_CLIENT = "TLS_CLIENT" | ||
| CONNECTION_TYPE_TLS_SERVER = "TLS_SERVER" | ||
| CONNECTION_TYPE_HTTP2_PREFACE = "HTTP2_PREFACE" | ||
| ) |
Contributor
There was a problem hiding this comment.
Is it worth having these defined for each protocol type, or should we have only client and server? (Or unknown?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: https://postmanlabs.atlassian.net/browse/POA-155
Confluence: https://postmanlabs.atlassian.net/l/cp/EtJHwV3u
Changes
Two sets of changes are included in this PR.
akita-libs/spec_utils/ir_hash, add the newly defined HTTPMethodMeta ingen.gomakeinakita-libs/spec_utils/ir_hashTODO
Update akita-ir version to match the commit on master once akita-ir#10 is merged