Adding latex snippets(wip)#23
Open
chhavi18387 wants to merge 6 commits intopoush:masterfrom
Open
Conversation
Collaborator
|
@chhavi18387 Thanks for the PR. Just go through ajaxorg/ace#3656 and quickly add the code for registering the snippets in our editor instance. |
shashaBot
requested changes
May 1, 2020
Collaborator
shashaBot
left a comment
shashaBot
left a comment
There was a problem hiding this comment.
Please remove README.md changes from this PR. A separate PR related to documentation would be a better place for these changes.
Author
|
Yes @shashaBot but I actually happened to merge the documentation changes into the master branch of the forked repository. Could you please look into the documentation PR I've made and tell me if there's some scope for improvement? Also, I'd improve the local server setup instruction as @escher-m mentioned in issue #14 and I'll update you soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a work in progress pull request with reference to issue #10