Skip to content

Create ui-events.js. (winp)#24

Closed
escher-m wants to merge 1 commit intopoush:masterfrom
escher-m:patch-1
Closed

Create ui-events.js. (winp)#24
escher-m wants to merge 1 commit intopoush:masterfrom
escher-m:patch-1

Conversation

@escher-m
Copy link
Copy Markdown

@escher-m escher-m commented Apr 29, 2020

for adding spinner during compiling

-Team BigUhOh (RGSoC '20)

@escher-m escher-m changed the title Create ui-events.js Create ui-events.js. (winp) Apr 29, 2020
@poush poush requested review from jainaman224 and shashaBot April 30, 2020 09:15
Copy link
Copy Markdown
Collaborator

@shashaBot shashaBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The JavaScript code fails with SyntaxError. Also, you don't need to create a new event. Just listen for the onclick event.

@shashaBot
Copy link
Copy Markdown
Collaborator

Closing this PR, please make required changes and include them in #25 itself.

@shashaBot shashaBot closed this May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants