Skip to content

Jp/float support #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
melkyades merged 3 commits into from
Jun 8, 2025
Merged

Jp/float support #135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
210c660
[kernel] add st code for float support
melkyades Jun 8, 2025
2d88158
[vm-cpp] add float primitives
melkyades Jun 8, 2025
e7a9f15
[vm-pharo] implement primitive to create floats from integers
melkyades Jun 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
177 changes: 47 additions & 130 deletions modules/Kernel/Float.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@ Class {

{ #category : #private }
Float class >> basicErrorOn: aSymbol status: status for: aNumber [
self error: 'Float error ' , aSymbol
self error: 'Float error ' , aSymbol.
#FloatPlus. #FloatMinus. #FloatMultiply. #FloatDiv. #FloatLess. #FloatEqual.
#FloatFractionPart. #FloatSignificand. #FloatSqrt. #FloatTimesTwoPower. #FloatTruncated "hack to get the symbols interned in kernel"
]

{ #category : #errors }
Expand Down Expand Up @@ -61,29 +63,21 @@ Float class >> from: aNumber [

{ #category : #'instance creation' }
Float class >> fromByteArray: aByteArray [
| float size |
float := self new.
size := float size.
float
replaceBytesFrom: 1
to: size
with: aByteArray
startingAt: 1.
^float
^self new initializeWith: aByteArray
]

{ #category : #'instance creation' }
Float class >> fromBytes: anObject [
| float |
^anObject isByteArray ifTrue: [self fromByteArray: anObject] ifFalse: [
float := self new.
float replaceBytesFrom: 1 to: 8 with: anObject startingAt: 1.
^float]
]

{ #category : #'instance creation' }
Float class >> fromInteger: anInteger [
| result |
result := Float new.
anInteger _isSmallInteger ifTrue: [
Float clearStatusFlags.
anInteger _asNative _asFloatInto: result.
^result].
anInteger isInteger
ifTrue: [^(self fromInteger: (anInteger bitShift: -24)) * 16r1000000 asFloat
+ (self fromInteger: (anInteger bitAnd: 16rFFFFFF))]
ifFalse: [self error: 'number is not an integer']
^self errorVMSpecific
]

{ #category : #'instance creation' }
Expand Down Expand Up @@ -133,7 +127,7 @@ Float class >> hasDenormalizedOperandFlag: status [

{ #category : #testing }
Float class >> hasErrorFlag: status [
^(status bitAnd: 0x1F) ~= 0
^(status bitAnd: 0x1F) != 0
]

{ #category : #testing }
Expand Down Expand Up @@ -357,7 +351,7 @@ Float class >> statusVar [

{ #category : #'instance creation' }
Float class >> usingBytes: aByteArray [
^self fromByteArray: aByteArray
^self new initializeWith: aByteArray
]

{ #category : #constants }
Expand All @@ -367,44 +361,17 @@ Float class >> zero [

{ #category : #arithmetic }
Float >> - aNumber [
| result status |
aNumber isFloat ifFalse: [^self - aNumber asFloat].
result := Float new.
Float clearStatusFlags.
self _floatMinus: aNumber into: result.
status := Float status.
(Float hasErrorFlag: status) ifFalse: [^result].
^(Float hasDenormalizedOperandFlag: status)
ifTrue: [self asNormalized - aNumber asNormalized]
ifFalse: [self errorOn: #'-' status: status]
^self errorVMSpecific
]

{ #category : #arithmetic }
Float >> * aNumber [
| result status |
aNumber isFloat ifFalse: [^self * aNumber asFloat].
result := Float new.
Float clearStatusFlags.
self _floatMultiply: aNumber into: result.
status := Float status.
(Float hasErrorFlag: status) ifFalse: [^result].
^(Float hasDenormalizedOperandFlag: status)
ifTrue: [self asNormalized * aNumber asNormalized]
ifFalse: [self errorOn: #'*' status: status]
^self errorVMSpecific
]

{ #category : #arithmetic }
Float >> / aNumber [
| result status |
aNumber isFloat ifFalse: [^self / aNumber asFloat].
result := Float new.
Float clearStatusFlags.
self _floatQuotient: aNumber into: result.
status := Float status.
(Float hasErrorFlag: status) ifFalse: [^result].
^(Float hasDenormalizedOperandFlag: status)
ifTrue: [self asNormalized / aNumber asNormalized]
ifFalse: [self errorOn: #'/' status: status]
^self errorVMSpecific
]

{ #category : #arithmetic }
Expand Down Expand Up @@ -432,29 +399,12 @@ Float >> ~ aFloat [

{ #category : #arithmetic }
Float >> + aNumber [
| result status |
aNumber isFloat ifFalse: [^aNumber addTo: self].
result := Float new.
Float clearStatusFlags.
self _floatPlus: aNumber into: result.
status := Float status.
(Float hasErrorFlag: status) ifFalse: [^result].
^(Float hasDenormalizedOperandFlag: status)
ifTrue: [self asNormalized + aNumber asNormalized]
ifFalse: [self errorOn: #'+' status: status]
^self errorVMSpecific
]

{ #category : #comparing }
Float >> < aNumber [
| result status |
aNumber isFloat ifFalse: [^self < aNumber asFloat].
Float clearStatusFlags.
result := 0 == (self _floatLessThan: aNumber).
status := Float status.
(Float hasErrorFlag: status) ifFalse: [^result].
(Float hasDenormalizedOperandFlag: status) ifTrue: [^result].
(self isSpecialValue or: [aNumber isSpecialValue]) ifTrue: [^result].
self errorOn: #'<' status: status
^self errorVMSpecific
]

{ #category : #comparing }
Expand All @@ -471,21 +421,7 @@ Float >> <= aNumber [

{ #category : #comparing }
Float >> = aNumber [
| result status nan equal |
aNumber isFloat
ifFalse: [^aNumber isNumber
ifTrue: [self = aNumber asFloat]
ifFalse: [false]].
Float clearStatusFlags.
result := 0 == (self _floatEquals: aNumber).
status := Float status.
(Float hasErrorFlag: status) ifFalse: [^result].
(Float hasDenormalizedOperandFlag: status) ifTrue: [^result].
nan := self isNaN.
equal := nan == aNumber isNaN.
equal ifFalse: [^false].
nan ifTrue: [^true].
self errorOn: #'=' status: status
^self errorVMSpecific
]

{ #category : #comparing }
Expand Down Expand Up @@ -571,6 +507,16 @@ Float >> asTrueFraction [
^numerator / denominator
]

{ #category : #testing }
Float >> at: index [
^self errorVMSpecific
]

{ #category : #testing }
Float >> basicAt: index [
^self errorVMSpecific
]

{ #category : #arithmetic }
Float >> ceiling [
^self isNaN ifTrue: [self] ifFalse: [super ceiling]
Expand All @@ -591,6 +537,11 @@ Float >> degreesToRadians [
^self * RadiansPerDegree
]

{ #category : #random }
Float >> errorOn: aSymbol [
^self errorVMSpecific
]

{ #category : #errors }
Float >> errorOn: aSymbol status: anInteger [
^self class errorOn: aSymbol status: anInteger for: self
Expand Down Expand Up @@ -618,15 +569,7 @@ Float >> floor [

{ #category : #random }
Float >> fractionPart [
| fraction status |
fraction := Float new.
Float clearStatusFlags.
self _floatFractionPartInto: fraction.
status := Float status.
(Float hasErrorFlag: status) ifFalse: [^fraction].
^(Float hasDenormalizedOperandFlag: status)
ifTrue: [self asNormalized fractionPart]
ifFalse: [self errorOn: #fractionPart status: status]
^self errorVMSpecific
]

{ #category : #testing }
Expand Down Expand Up @@ -668,6 +611,11 @@ Float >> hasZeroMantissa [
^(self at: 1) = 0
]

{ #category : #random }
Float >> initializeWith: bytes [
self errorVMSpecific
]

{ #category : #testing }
Float >> isDenormalizedValue [
^self hasZeroExponent and: [self hasZeroMantissa not]
Expand Down Expand Up @@ -859,11 +807,7 @@ Float >> sign [

{ #category : #accessing }
Float >> significand [
| status |
status := Float status.
^(Float hasDenormalizedOperandFlag: status)
ifTrue: [self asNormalized significand]
ifFalse: [self errorOn: #significand status: status]
^self errorVMSpecific
]

{ #category : #trigonometry }
Expand All @@ -878,15 +822,7 @@ Float >> sizeInBytes [

{ #category : #functions }
Float >> sqrt [
| result status |
result := Float new.
Float clearStatusFlags.
self _floatSqrtInto: result.
status := Float status.
(Float hasErrorFlag: status) ifFalse: [^result].
^(Float hasDenormalizedOperandFlag: status)
ifTrue: [self asNormalized sqrt]
ifFalse: [self errorOn: #sqrt status: status]
^self errorVMSpecific
]

{ #category : #printing }
Expand All @@ -901,31 +837,12 @@ Float >> tan [

{ #category : #arithmetic }
Float >> timesTwoPower: anInteger [
| result status |
result := self copy.
result _timesTwoPower: anInteger asFloat.
status := Float status.
(Float hasErrorFlag: status) ifFalse: [^result].
self errorOn: #timesTwoPower status: status
^self errorVMSpecific
]

{ #category : #arithmetic }
Float >> truncated [
| result status |
Float clearStatusFlags.
result := self _floatTruncated.
status := Float status.
((Float hasErrorFlag: status) not
and: [result = 0 or: [result sign = self sign]])
ifTrue: [^result].
self isSpecialValue ifTrue: [^self].
^self abs < 2.0e16
ifTrue: [| q r |
q := self quo: 536870912.0.
"((SmallInteger largestPositive bitShift: -1) + 1) asFloat"
r := self - (q asFloat * 536870912.0).
q * 536870912 + r truncated]
ifFalse: [self asTrueFraction]
^self errorVMSpecific
]

{ #category : #private }
Expand Down
Loading