Skip to content

Chore: Update packages#40

Merged
stevensJourney merged 10 commits into
mainfrom
update-packages
May 27, 2026
Merged

Chore: Update packages#40
stevensJourney merged 10 commits into
mainfrom
update-packages

Conversation

@stevensJourney
Copy link
Copy Markdown
Collaborator

@stevensJourney stevensJourney commented May 4, 2026

This bumps external dependencies, in order to avoid some warnings provided by tools such as NPMX.

An example of a recent report

image

The above seems to contain strange warnings. E.g. we didn't explicitly increase our dependency requirements between versions - perhaps this is related to internal dependencies. We also don't use that version of glob in our codebase.

After bumping these versions, a pnpm audit currently shows these items

❯ pnpm audit
┌─────────────────────┬────────────────────────────────────────────────────────┐
│ moderate            │ uuid: Missing buffer bounds check in v3/v5/v6 when buf │
│                     │ is provided                                            │
├─────────────────────┼────────────────────────────────────────────────────────┤
│ Package             │ uuid                                                   │
├─────────────────────┼────────────────────────────────────────────────────────┤
│ Vulnerable versions │ <14.0.0                                                │
├─────────────────────┼────────────────────────────────────────────────────────┤
│ Patched versions    │ >=14.0.0                                               │
├─────────────────────┼────────────────────────────────────────────────────────┤
│ Paths               │ cli>@journeyapps-labs/common-utils>uuid                │
│                     │                                                        │
│                     │ cli>@powersync/service-sync-rules>uuid                 │
│                     │                                                        │
│                     │ packages__editor>nitro-nightly>unstorage>@azure/       │
│                     │ identity>@azure/msal-node>uuid                         │
├─────────────────────┼────────────────────────────────────────────────────────┤
│ More info           │ https://github.com/advisories/GHSA-w5hq-g745-h8pq      │
└─────────────────────┴────────────────────────────────────────────────────────┘
┌─────────────────────┬────────────────────────────────────────────────────────┐
│ low                 │ Arbitrary File Write in cli                            │
├─────────────────────┼────────────────────────────────────────────────────────┤
│ Package             │ cli                                                    │
├─────────────────────┼────────────────────────────────────────────────────────┤
│ Vulnerable versions │ <1.0.0                                                 │
├─────────────────────┼────────────────────────────────────────────────────────┤
│ Patched versions    │ >=1.0.0                                                │
├─────────────────────┼────────────────────────────────────────────────────────┤
│ Paths               │ cli                                                    │
├─────────────────────┼────────────────────────────────────────────────────────┤
│ More info           │ https://github.com/advisories/GHSA-6cpc-mj5c-m9rq      │
└─────────────────────┴────────────────────────────────────────────────────────┘
4 vulnerabilities found
Severity: 1 low | 3 moderate

Where the cli seems to be a false match of our /cli folder, to the cli package published to npm. The uuid entry requires changes to the mentioned packages.

TODOs:

  • Bump uuid package in sub dependencies

Additional Fix

As an additional fix, this fixes the release flow to build installers' artifacts in the same workflow as the release workflow (in a separate job). Currently, the onRelease workflow is not triggered, due to blocked recursive Github actions invocations.

@stevensJourney
Copy link
Copy Markdown
Collaborator Author

The current remaining sources of uuid are from @journeyapps-labs/common-sdk and @journeyapps-labs/common-utils. The uuid dependency was removed from those in journeyapps-labs/common#17 - however the publishing pipeline seems to be broken in that repo at the moment. These packages use ^ range dependencies, so they should automatically update once they are actually released.

I've configured Dependabot to automatically check for updates and create update PRs.

@stevensJourney stevensJourney marked this pull request as ready for review May 27, 2026 08:44
@stevensJourney stevensJourney requested a review from LucDeCaf May 27, 2026 08:44
Copy link
Copy Markdown

@LucDeCaf LucDeCaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I noticed we added oclif to the PNPM catalog; I'm guessing that's just to make applying the patch across all our packages easier, but I think we should also consider adding other shared dependencies to the catalog (eg. typescript, @types/*).

@stevensJourney
Copy link
Copy Markdown
Collaborator Author

LGTM. I noticed we added oclif to the PNPM catalog; I'm guessing that's just to make applying the patch across all our packages easier, but I think we should also consider adding other shared dependencies to the catalog (eg. typescript, @types/*).

Jip, we should share more catalog versions in future :)

@stevensJourney stevensJourney merged commit 284e9cb into main May 27, 2026
6 checks passed
@stevensJourney stevensJourney deleted the update-packages branch May 27, 2026 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants