dockerImage param is not required anymore for backend actions #70
Conversation
…itories Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier.pro@gmail.com>
Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier.pro@gmail.com>
Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier.pro@gmail.com>
Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier.pro@gmail.com>
Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier.pro@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR makes the dockerImage parameter optional in GitHub Actions workflows for backend applications, enabling support for multi-module repositories where Docker image names are defined in pom.xml configuration.
Changes:
- Changed
dockerImageinput parameter from required to optional across four workflow files - Updated Docker deployment commands to conditionally use the
dockerImageparameter when provided - Modified tagging strategy in release and patch workflows to use separate tags parameter
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/release-backend-app-generic.yml | Made dockerImage optional and updated deployment to use conditional parameter substitution with separate tags |
| .github/workflows/patch-backend-app-generic.yml | Made dockerImage optional and updated deployment to use conditional parameter substitution with separate tags |
| .github/workflows/manual-dockerdeploy-backend-app-generic.yml | Made dockerImage optional and updated deployment to use conditional parameter substitution |
| .github/workflows/build-backend-app-generic.yml | Made dockerImage optional and updated deployment to use conditional parameter substitution |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| -Djib.httpTimeout=60000 | ||
| -Djib.to.image="$RUNGHA_DOCKER_IMAGE:$GITHUB_SHORT_VERSION" | ||
| ${RUNGHA_DOCKER_IMAGE:+-Djib.to.image="$RUNGHA_DOCKER_IMAGE"} | ||
| -Djib.to.tags="$GITHUB_SHORT_VERSION" |
There was a problem hiding this comment.
The image and tags are now specified separately, but when RUNGHA_DOCKER_IMAGE is not provided, -Djib.to.tags will still attempt to tag an image that may not have been explicitly named. This could lead to ambiguity about which image is being tagged. Consider documenting this behavior or ensuring the pom.xml configuration properly handles the tagging when no explicit image name is provided.
| -Djib.to.tags="$GITHUB_SHORT_VERSION" | |
| ${RUNGHA_DOCKER_IMAGE:+-Djib.to.tags="$GITHUB_SHORT_VERSION"} |
| -Djib.to.image="$RUNGHA_DOCKER_IMAGE:$CURRENT_TAG_VERSION" | ||
| ${RUNGHA_DOCKER_IMAGE:+-Djib.to.image="$RUNGHA_DOCKER_IMAGE"} | ||
| -Djib.to.auth.username="$RUNGHA_DOCKER_USERNAME" | ||
| -Djib.to.auth.password="$RUNGHA_DOCKER_RELEASE" |
There was a problem hiding this comment.
Unlike the release and patch workflows, this workflow does not include the -Djib.to.tags parameter to specify the version tag (CURRENT_TAG_VERSION). This inconsistency means the tagging behavior differs between workflows, which could lead to unexpected results when dockerImage is not provided.
| -Djib.to.auth.password="$RUNGHA_DOCKER_RELEASE" | |
| -Djib.to.auth.password="$RUNGHA_DOCKER_RELEASE" | |
| -Djib.to.tags="$CURRENT_TAG_VERSION" |
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
"dockerImage" is a required param
It does not allow us to create multiple images from a multi-module repository
What is the new behavior (if this is a feature change)?
"dockerImage" is not a required param
It will use default image name from pom.xml config
We can now use those actions for multi-module repositories
Does this PR introduce a breaking change or deprecate an API?