Skip to content

test(transaction): add MVCC snapshot and isolation level tests - #50

Merged
poyrazK merged 2 commits into
mainfrom
feat/txn-isolation-tests
Apr 19, 2026
Merged

test(transaction): add MVCC snapshot and isolation level tests#50
poyrazK merged 2 commits into
mainfrom
feat/txn-isolation-tests

Conversation

@poyrazK

@poyrazK poyrazK commented Apr 19, 2026

Copy link
Copy Markdown
Owner

Summary

  • Add 4 new tests for TransactionManager MVCC and isolation:
    • SnapshotCaptureSingleTxn: verify snapshot is valid when single transaction begins
    • SnapshotWithActiveTransactions: verify snapshot captures active transactions correctly
    • SnapshotAfterCommit: verify committed transactions are removed from snapshot
    • SerializableWriteSkewDetection: verify SERIALIZABLE isolation level is set

Test plan

  • Build and run transaction_manager_tests (12 tests pass)

@coderabbitai

coderabbitai Bot commented Apr 19, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@github-actions[bot] has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 34 minutes and 1 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 34 minutes and 1 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 044aeba1-e81f-431c-8dac-8f8633225347

📥 Commits

Reviewing files that changed from the base of the PR and between 3474c34 and 3b102f5.

📒 Files selected for processing (2)
  • tests/operator_tests.cpp
  • tests/transaction_manager_tests.cpp
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/txn-isolation-tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@poyrazK poyrazK left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's okay to merge

@poyrazK
poyrazK merged commit 9890578 into main Apr 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant