Fix VM cleanup issue and improve VM deletion logic for containerd periodic jobs#310
Merged
AshwinHIBM merged 1 commit intoppc64le-cloud:mainfrom Apr 21, 2026
Merged
Conversation
ppc64le-cloud-bot
added
the
size/S
|
I am okay with these changes for now. I will raise another PR once this is merged to improve robustness of the scripts. |
AshwinHIBM
reviewed
Feb 25, 2026
AshwinHIBM
reviewed
Feb 25, 2026
AshwinHIBM
reviewed
Feb 25, 2026
AshwinHIBM
reviewed
Feb 25, 2026
AshwinHIBM
reviewed
Feb 25, 2026
AshwinHIBM
reviewed
Feb 25, 2026
Collaborator
|
Trying to adapt https://google.github.io/styleguide/shellguide.html in every new PR. |
bharti-0211
force-pushed
the
fix-vm-cleanup
branch
from
f71d59b to
657bd28
Compare
ppc64le-cloud-bot
added
size/M
Collaborator
|
Can you squash the commits? |
bharti-0211
force-pushed
the
fix-vm-cleanup
branch
from
d1677be to
2da364f
Compare
Collaborator
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AshwinHIBM, bharti-0211 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ppc64le-cloud-bot
added
the
approved
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures VM deletion in all cases even if the tests don't start running at all because of some early issue like inability to connect to the VM.
Fixes #311