Skip to content

Add s1122 machine-type to associated zones.#21

Merged
ppc64le-cloud-bot merged 1 commit intoppc64le-cloud:mainfrom
kishen-v:update-avl-mcs
Aug 20, 2025
Merged

Add s1122 machine-type to associated zones.#21
ppc64le-cloud-bot merged 1 commit intoppc64le-cloud:mainfrom
kishen-v:update-avl-mcs

Conversation

@kishen-v
Copy link
Copy Markdown
Contributor

@kishen-v kishen-v commented Aug 19, 2025

This PR:

  • Adds s1122 across available zones and updates the list of available machines.

Steps followed:

powervs-utils/region.go

Lines 9 to 12 in 7e43464

// The system types against each zone can be fetched using either of the following:
// 1. ibmcloud cli command
// `ibmcloud pi datacenter ls --json | jq -r '.datacenters[] | "\(.location.region),\(.capabilitiesDetails.supportedSystems.general[])"' | sort -u`
// 2. https://cloud.ibm.com/apidocs/power-cloud#v1-datacenters-getall (the above command uses this api underneath).

@kishen-v kishen-v requested a review from Karthik-K-N August 19, 2025 15:54
@ppc64le-cloud-bot ppc64le-cloud-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 19, 2025
Copy link
Copy Markdown
Contributor

@Karthik-K-N Karthik-K-N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the source of truth in the PR description.

Comment thread region.go
Copy link
Copy Markdown
Contributor

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ppc64le-cloud-bot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kishen-v, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 20, 2025
@mkumatag
Copy link
Copy Markdown
Contributor

/hold to address other review comments

@ppc64le-cloud-bot ppc64le-cloud-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 20, 2025
@kishen-v kishen-v requested a review from Karthik-K-N August 20, 2025 05:50
@ppc64le-cloud-bot ppc64le-cloud-bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2025
Copy link
Copy Markdown
Contributor

@Karthik-K-N Karthik-K-N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thank you.

@ppc64le-cloud-bot ppc64le-cloud-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2025
@kishen-v
Copy link
Copy Markdown
Contributor Author

/unhold
Addressed all comments concerning this PR.

@ppc64le-cloud-bot ppc64le-cloud-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 20, 2025
@ppc64le-cloud-bot ppc64le-cloud-bot merged commit d58d915 into ppc64le-cloud:main Aug 20, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants