Skip to content

Code Cleanup#864

Open
kishen-v wants to merge 2 commits intoppc64le-cloud:mainfrom
kishen-v:consolidate-imgbins
Open

Code Cleanup#864
kishen-v wants to merge 2 commits intoppc64le-cloud:mainfrom
kishen-v:consolidate-imgbins

Conversation

@kishen-v
Copy link
Contributor

@kishen-v kishen-v commented Feb 25, 2026

What this PR does / why we need it:
This PR contains the following changes:

  • Consolidate the required binaries required for qcow2ova image generation, as the current design tends to iterate through dependencies and provide hints as and when checked.

  • Replace NewPcloudEventsGetqueryParamsWithTimeout(pkg.TIMEOUT) with NewPcloudEventsGetqueryParams() as the pkg.TIMEOUT is set to 30 minutes for the API request to timeout. The default timeout with NewPcloudEventsGetqueryParams is 30 seconds and set at SDK level. The changes were tested and found to work reliably.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

**Output/Demonstration

Current behaviour:
E0224 22:36:15.117998   94081 main.go:26] check failed: exec: "qemu-img": executable file not found in $PATH
Hint: yum install qemu-img -y

Proposed:
E0224 22:40:55.066240   99013 main.go:26] check failed: executable file(s) not found in $PATH: qemu-img, growpart
Hint: yum install qemu-img -y
yum install cloud-utils-growpart -y

Release notes:

Display unavailable executables in $PATH that are required for image conversion

@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kishen-v
Once this PR has been reviewed and has the lgtm label, please assign mkumatag for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 25, 2026
@kishen-v kishen-v force-pushed the consolidate-imgbins branch from 3c52542 to 72f5ef1 Compare February 25, 2026 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants