getAnnIds: areaRng not inclusive of limits#5
Open
ashnair1 wants to merge 1 commit intoppwwyyxx:masterfrom
Open
getAnnIds: areaRng not inclusive of limits#5ashnair1 wants to merge 1 commit intoppwwyyxx:masterfrom
ashnair1 wants to merge 1 commit intoppwwyyxx:masterfrom
Conversation
Author
|
Hi @ppwwyyxx, any thoughts on this PR? |
Owner
|
Though I agree that the code is incorrect, this will change the evaluation results and therefore have major consequences. Please send it to the official repo instead of this fork. I do not want to diverge from the official repo in evaluation results, even when the official repo is wrong. |
Author
|
Fair enough. I've opened cocodataset/cocoapi#568 for this fix. |
Author
|
@ppwwyyxx Do you know who currently maintains the official repo? |
|
As far as I understood, official repo is not being maintained |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you were to query annotations within a particular area range, via the
getAnnIdsfunction, it ignores those objects that have areas equal to the limits.For example,
The assertion would fail if there are objects that have area exactly equal to 10^2, 32^2, 64^2 or 96 ^2 pixels.