Port: Format: Don't allow tabs by mkannwischer · Pull Request #1022 · pq-code-package/mldsa-native

mkannwischer · 2026-04-06T01:44:22Z

Ports Format: Don't allow tabs mlkem-native#1573

oqs-bot · 2026-04-06T02:03:11Z

CBMC Results (ML-DSA-44)

Full Results (185 proofs)

Proof	Status	Current	Previous	Change
`TOTAL`	✅	1768s	1671s	+5.8%
`sign_verify_internal`	✅	231s	225s	+3%
`rej_uniform_native`	✅	128s	123s	+4%
`polyvecl_pointwise_acc_montgomery_c`	✅	113s	100s	+13%
`poly_pointwise_montgomery_c`	✅	102s	103s	-1%
`mld_invntt_layer`	✅	99s	93s	+6%
`mld_ct_memcmp`	✅	76s	73s	+4%
`mld_attempt_signature_generation`	✅	49s	46s	+7%
`mld_ntt_layer`	✅	45s	40s	+12%
`polyvec_matrix_expand_eager`	✅	32s	31s	+3%
`fqmul`	✅	28s	28s	+0%
`keccakf1600x4_permute_native`	✅	27s	21s	+29%
`sign_keypair_internal`	✅	24s	24s	+0%
`sign_signature_internal`	✅	22s	21s	+5%
`polyt0_unpack`	✅	20s	18s	+11%
`rej_uniform`	✅	20s	20s	+0%
`poly_chknorm_c`	✅	19s	17s	+12%
`sign_pk_from_sk`	✅	18s	20s	-10%
`mld_ntt_butterfly_block`	✅	16s	13s	+23%
`poly_uniform_eta_4x`	✅	15s	10s	+50%
`rej_uniform_c`	✅	15s	15s	+0%
`polyveck_decompose`	✅	14s	12s	+17%
`polyz_unpack_c`	✅	13s	10s	+30%
`polyvec_matrix_expand_eager_serial`	✅	12s	9s	+33%
`poly_uniform_4x`	✅	11s	12s	-8%
`keccak_absorb_once_x4`	✅	10s	9s	+11%
`poly_add`	✅	10s	12s	-17%
`mld_check_pct`	✅	9s	10s	-10%
`polyveck_chknorm`	✅	9s	8s	+12%
`sign`	✅	8s	7s	+14%
`unpack_sk`	✅	8s	5s	+60%
`keccakf1600_permute_native`	✅	7s	8s	-12%
`mld_compute_pack_z`	✅	7s	5s	+40%
`poly_invntt_tomont_c`	✅	7s	7s	+0%
`poly_sub`	✅	7s	3s	+133%
`polyvec_matrix_pointwise_montgomery_eager`	✅	7s	5s	+40%
`polyveck_power2round`	✅	7s	8s	-12%
`caddq`	✅	6s	4s	+50%
`keccak_absorb`	✅	6s	7s	-14%
`keccak_squeeze`	✅	6s	5s	+20%
`mld_h`	✅	6s	3s	+100%
`pack_sig_h_poly`	✅	6s	1s	+500%
`pointwise_acc_native_x86_64`	✅	6s	8s	-25%
`poly_power2round`	✅	6s	5s	+20%
`poly_reduce`	✅	6s	3s	+100%
`polyeta_unpack`	✅	6s	5s	+20%
`polyveck_sub`	✅	6s	6s	+0%
`rej_eta`	✅	6s	3s	+100%
`sign_signature`	✅	6s	4s	+50%
`sign_signature_pre_hash_internal`	✅	6s	3s	+100%
`sign_verify_extmu`	✅	6s	6s	+0%
`keccak_squeezeblocks_x4`	✅	5s	4s	+25%
`keccakf1600_permute`	✅	5s	8s	-38%
`pointwise_acc_native_aarch64`	✅	5s	5s	+0%
`pointwise_native_aarch64`	✅	5s	3s	+67%
`poly_caddq_native_aarch64`	✅	5s	3s	+67%
`poly_challenge`	✅	5s	6s	-17%
`poly_chknorm`	✅	5s	3s	+67%
`poly_permute_bitrev_to_custom_optional_native`	✅	5s	4s	+25%
`poly_shiftl`	✅	5s	3s	+67%
`poly_uniform_gamma1_4x`	✅	5s	5s	+0%
`poly_use_hint_c`	✅	5s	3s	+67%
`polyt0_pack`	✅	5s	5s	+0%
`polyveck_ntt`	✅	5s	4s	+25%
`polyveck_shiftl`	✅	5s	7s	-29%
`polyvecl_ntt`	✅	5s	3s	+67%
`polyvecl_uniform_gamma1_serial`	✅	5s	2s	+150%
`polyvecl_unpack_z`	✅	5s	4s	+25%
`shake128_squeeze`	✅	5s	5s	+0%
`sign_open`	✅	5s	4s	+25%
`sign_verify_pre_hash_shake256`	✅	5s	6s	-17%
`unpack_hints`	✅	5s	6s	-17%
`unpack_pk`	✅	5s	3s	+67%
`make_hint`	✅	4s	2s	+100%
`mld_ct_abs_i32`	✅	4s	4s	+0%
`mld_ct_cmask_nonzero_u8`	✅	4s	2s	+100%
`mld_keccakf1600_extract_bytes`	✅	4s	3s	+33%
`mld_sample_s1_s2_serial`	✅	4s	3s	+33%
`montgomery_reduce`	✅	4s	3s	+33%
`ntt_native_x86_64`	✅	4s	6s	-33%
`pack_pk`	✅	4s	4s	+0%
`pack_sk_s1`	✅	4s	4s	+0%
`pointwise_native_x86_64`	✅	4s	2s	+100%
`poly_caddq_c`	✅	4s	3s	+33%
`poly_caddq_native`	✅	4s	3s	+33%
`poly_decompose_native`	✅	4s	4s	+0%
`poly_make_hint`	✅	4s	3s	+33%
`poly_ntt_native`	✅	4s	2s	+100%
`poly_permute_bitrev_to_custom_optional`	✅	4s	1s	+300%
`poly_uniform`	✅	4s	3s	+33%
`poly_use_hint_native`	✅	4s	2s	+100%
`polyveck_add`	✅	4s	4s	+0%
`polyveck_caddq`	✅	4s	6s	-33%
`polyvecl_pack_eta`	✅	4s	3s	+33%
`polyvecl_pointwise_acc_montgomery`	✅	4s	3s	+33%
`polyvecl_unpack_eta`	✅	4s	3s	+33%
`polyz_pack`	✅	4s	4s	+0%
`polyz_unpack_native`	✅	4s	4s	+0%
`power2round`	✅	4s	2s	+100%
`rej_eta_c`	✅	4s	5s	-20%
`rej_eta_native`	✅	4s	5s	-20%
`shake128_finalize`	✅	4s	2s	+100%
`shake256`	✅	4s	3s	+33%
`shake256x4_squeezeblocks`	✅	4s	4s	+0%
`sign_signature_pre_hash_shake256`	✅	4s	6s	-33%
`decompose`	✅	3s	3s	+0%
`fqscale`	✅	3s	4s	-25%
`intt_native_x86_64`	✅	3s	1s	+200%
`keccak_f1600_x4_native_aarch64_v8a_scalar_hybrid`	✅	3s	4s	-25%
`keccak_finalize`	✅	3s	2s	+50%
`keccak_init`	✅	3s	2s	+50%
`keccakf1600_xor_bytes (big endian)`	✅	3s	1s	+200%
`keccakf1600x4_extract_bytes`	✅	3s	3s	+0%
`keccakf1600x4_permute`	✅	3s	3s	+0%
`mld_ct_cmask_neg_i32`	✅	3s	2s	+50%
`mld_ct_get_optblocker_u32`	✅	3s	3s	+0%
`mld_ct_get_optblocker_u8`	✅	3s	1s	+200%
`mld_ct_sel_int32`	✅	3s	3s	+0%
`mld_sample_s1_s2`	✅	3s	3s	+0%
`mld_value_barrier_u32`	✅	3s	1s	+200%
`ntt_native_aarch64`	✅	3s	2s	+50%
`pack_sig_c`	✅	3s	5s	-40%
`pack_sig_z`	✅	3s	3s	+0%
`pack_sk_rho_key_tr_s2_t0`	✅	3s	2s	+50%
`poly_chknorm_native`	✅	3s	3s	+0%
`poly_chknorm_native_aarch64`	✅	3s	4s	-25%
`poly_decompose_c`	✅	3s	4s	-25%
`poly_invntt_tomont_native`	✅	3s	3s	+0%
`poly_pointwise_montgomery_native`	✅	3s	4s	-25%
`poly_uniform_gamma1`	✅	3s	4s	-25%
`poly_use_hint`	✅	3s	4s	-25%
`polyt1_pack`	✅	3s	4s	-25%
`polyveck_invntt_tomont`	✅	3s	3s	+0%
`polyveck_pack_eta`	✅	3s	2s	+50%
`polyveck_pointwise_poly_montgomery`	✅	3s	2s	+50%
`polyveck_reduce`	✅	3s	4s	-25%
`polyveck_unpack_eta`	✅	3s	4s	-25%
`polyveck_unpack_t0`	✅	3s	3s	+0%
`polyveck_use_hint`	✅	3s	3s	+0%
`polyvecl_chknorm`	✅	3s	4s	-25%
`reduce32`	✅	3s	3s	+0%
`shake128_release`	✅	3s	2s	+50%
`shake128x4_squeezeblocks`	✅	3s	5s	-40%
`shake256_init`	✅	3s	1s	+200%
`shake256_release`	✅	3s	2s	+50%
`shake256_squeeze`	✅	3s	2s	+50%
`sign_signature_extmu`	✅	3s	3s	+0%
`sign_verify`	✅	3s	6s	-50%
`sign_verify_pre_hash_internal`	✅	3s	6s	-50%
`use_hint`	✅	3s	3s	+0%
`keccak_f1600_x1_native_aarch64`	✅	2s	2s	+0%
`keccak_f1600_x1_native_aarch64_v84a`	✅	2s	2s	+0%
`keccak_f1600_x4_native_aarch64_v84a`	✅	2s	2s	+0%
`keccak_f1600_x4_native_aarch64_v8a_v84a_scalar_hybrid`	✅	2s	3s	-33%
`keccakf1600_extract_bytes (big endian)`	✅	2s	1s	+100%
`keccakf1600_xor_bytes`	✅	2s	2s	+0%
`keccakf1600x4_xor_bytes`	✅	2s	2s	+0%
`mld_ct_get_optblocker_i64`	✅	2s	3s	-33%
`mld_prepare_domain_separation_prefix`	✅	2s	5s	-60%
`mld_value_barrier_i64`	✅	2s	1s	+100%
`mld_value_barrier_u8`	✅	2s	2s	+0%
`poly_caddq`	✅	2s	5s	-60%
`poly_decompose`	✅	2s	3s	-33%
`poly_invntt_tomont`	✅	2s	1s	+100%
`poly_ntt`	✅	2s	2s	+0%
`poly_ntt_c`	✅	2s	4s	-50%
`poly_pointwise_montgomery`	✅	2s	4s	-50%
`poly_uniform_eta`	✅	2s	5s	-60%
`polyeta_pack`	✅	2s	4s	-50%
`polyt1_unpack`	✅	2s	3s	-33%
`polyveck_pack_t0`	✅	2s	3s	-33%
`polyveck_pack_w1`	✅	2s	3s	-33%
`polyvecl_pointwise_acc_montgomery_native`	✅	2s	3s	-33%
`polyw1_pack`	✅	2s	4s	-50%
`polyz_unpack`	✅	2s	2s	+0%
`shake128_absorb`	✅	2s	2s	+0%
`shake256_absorb`	✅	2s	4s	-50%
`shake256_finalize`	✅	2s	2s	+0%
`sign_keypair`	✅	2s	3s	-33%
`unpack_sig`	✅	2s	2s	+0%
`mld_ct_cmask_nonzero_u32`	✅	1s	4s	-75%
`polyvecl_uniform_gamma1`	✅	1s	4s	-75%
`shake128_init`	✅	1s	2s	-50%
`shake128x4_absorb_once`	✅	1s	1s	+0%
`shake256x4_absorb_once`	✅	1s	1s	+0%
`sys_check_capability`	✅	1s	1s	+0%

oqs-bot · 2026-04-06T02:04:10Z

CBMC Results (ML-DSA-87)

Full Results (185 proofs)

Proof	Status	Current	Previous	Change
`TOTAL`	✅	2258s	2300s	-1.8%
`sign_verify_internal`	✅	274s	286s	-4%
`polyvecl_pointwise_acc_montgomery_c`	✅	273s	282s	-3%
`polyvec_matrix_expand_eager`	✅	143s	150s	-5%
`rej_uniform_native`	✅	124s	129s	-4%
`poly_pointwise_montgomery_c`	✅	105s	115s	-9%
`mld_invntt_layer`	✅	92s	97s	-5%
`mld_attempt_signature_generation`	✅	79s	82s	-4%
`mld_ct_memcmp`	✅	74s	79s	-6%
`polyvec_matrix_expand_eager_serial`	✅	64s	62s	+3%
`sign_keypair_internal`	✅	48s	49s	-2%
`mld_ntt_layer`	✅	41s	45s	-9%
`fqmul`	✅	27s	29s	-7%
`keccakf1600x4_permute_native`	✅	24s	23s	+4%
`sign_pk_from_sk`	✅	24s	24s	+0%
`sign_signature_internal`	✅	24s	26s	-8%
`polyt0_unpack`	✅	21s	20s	+5%
`rej_uniform`	✅	21s	23s	-9%
`poly_chknorm_c`	✅	18s	18s	+0%
`polyveck_sub`	✅	18s	17s	+6%
`polyveck_chknorm`	✅	17s	14s	+21%
`polyveck_decompose`	✅	17s	19s	-11%
`mld_ntt_butterfly_block`	✅	16s	17s	-6%
`polyveck_add`	✅	15s	13s	+15%
`rej_uniform_c`	✅	15s	16s	-6%
`poly_uniform_4x`	✅	13s	10s	+30%
`poly_uniform_eta_4x`	✅	12s	13s	-8%
`polyvec_matrix_pointwise_montgomery_eager`	✅	12s	11s	+9%
`mld_check_pct`	✅	10s	10s	+0%
`mld_compute_pack_z`	✅	10s	12s	-17%
`poly_add`	✅	10s	13s	-23%
`polyveck_invntt_tomont`	✅	10s	9s	+11%
`polyveck_pointwise_poly_montgomery`	✅	10s	9s	+11%
`keccak_absorb_once_x4`	✅	8s	9s	-11%
`pointwise_acc_native_aarch64`	✅	8s	7s	+14%
`pointwise_acc_native_x86_64`	✅	8s	9s	-11%
`polyveck_power2round`	✅	8s	8s	+0%
`polyveck_reduce`	✅	8s	8s	+0%
`polyvecl_ntt`	✅	8s	7s	+14%
`sign`	✅	8s	8s	+0%
`sign_signature_extmu`	✅	8s	5s	+60%
`keccakf1600_permute`	✅	7s	6s	+17%
`keccakf1600_permute_native`	✅	7s	7s	+0%
`mld_sample_s1_s2_serial`	✅	7s	7s	+0%
`poly_invntt_tomont_c`	✅	7s	8s	-12%
`poly_power2round`	✅	7s	7s	+0%
`poly_uniform_gamma1_4x`	✅	7s	3s	+133%
`polyveck_ntt`	✅	7s	9s	-22%
`polyvecl_pointwise_acc_montgomery`	✅	7s	6s	+17%
`keccak_absorb`	✅	6s	8s	-25%
`keccak_squeezeblocks_x4`	✅	6s	5s	+20%
`keccakf1600x4_xor_bytes`	✅	6s	2s	+200%
`mld_sample_s1_s2`	✅	6s	5s	+20%
`poly_challenge`	✅	6s	4s	+50%
`poly_decompose_c`	✅	6s	7s	-14%
`polyz_pack`	✅	6s	2s	+200%
`sign_open`	✅	6s	3s	+100%
`sign_verify_pre_hash_internal`	✅	6s	4s	+50%
`decompose`	✅	5s	4s	+25%
`fqscale`	✅	5s	3s	+67%
`intt_native_x86_64`	✅	5s	4s	+25%
`keccak_f1600_x4_native_aarch64_v84a`	✅	5s	1s	+400%
`keccak_squeeze`	✅	5s	6s	-17%
`pack_sk_rho_key_tr_s2_t0`	✅	5s	3s	+67%
`pointwise_native_aarch64`	✅	5s	4s	+25%
`poly_caddq_c`	✅	5s	6s	-17%
`poly_shiftl`	✅	5s	5s	+0%
`poly_use_hint`	✅	5s	4s	+25%
`poly_use_hint_native`	✅	5s	2s	+150%
`polyeta_unpack`	✅	5s	6s	-17%
`polyt1_pack`	✅	5s	4s	+25%
`polyveck_caddq`	✅	5s	5s	+0%
`polyveck_use_hint`	✅	5s	6s	-17%
`polyvecl_pointwise_acc_montgomery_native`	✅	5s	3s	+67%
`polyvecl_uniform_gamma1`	✅	5s	4s	+25%
`polyvecl_uniform_gamma1_serial`	✅	5s	4s	+25%
`polyvecl_unpack_eta`	✅	5s	4s	+25%
`reduce32`	✅	5s	2s	+150%
`rej_eta_c`	✅	5s	5s	+0%
`shake128x4_squeezeblocks`	✅	5s	3s	+67%
`sign_keypair`	✅	5s	4s	+25%
`sign_signature`	✅	5s	4s	+25%
`sign_signature_pre_hash_internal`	✅	5s	5s	+0%
`sign_verify_extmu`	✅	5s	2s	+150%
`unpack_sk`	✅	5s	5s	+0%
`caddq`	✅	4s	4s	+0%
`keccakf1600_xor_bytes`	✅	4s	3s	+33%
`keccakf1600_xor_bytes (big endian)`	✅	4s	3s	+33%
`make_hint`	✅	4s	4s	+0%
`mld_h`	✅	4s	4s	+0%
`mld_keccakf1600_extract_bytes`	✅	4s	4s	+0%
`ntt_native_x86_64`	✅	4s	2s	+100%
`pack_sig_h_poly`	✅	4s	3s	+33%
`pack_sk_s1`	✅	4s	4s	+0%
`poly_caddq`	✅	4s	4s	+0%
`poly_caddq_native_aarch64`	✅	4s	2s	+100%
`poly_ntt`	✅	4s	2s	+100%
`poly_ntt_c`	✅	4s	3s	+33%
`poly_pointwise_montgomery`	✅	4s	2s	+100%
`poly_sub`	✅	4s	4s	+0%
`polyeta_pack`	✅	4s	2s	+100%
`polyt0_pack`	✅	4s	7s	-43%
`polyt1_unpack`	✅	4s	2s	+100%
`polyveck_pack_w1`	✅	4s	4s	+0%
`polyveck_shiftl`	✅	4s	7s	-43%
`polyveck_unpack_eta`	✅	4s	4s	+0%
`polyvecl_chknorm`	✅	4s	5s	-20%
`shake128_finalize`	✅	4s	4s	+0%
`shake256_init`	✅	4s	2s	+100%
`sign_signature_pre_hash_shake256`	✅	4s	3s	+33%
`sign_verify`	✅	4s	5s	-20%
`sign_verify_pre_hash_shake256`	✅	4s	5s	-20%
`sys_check_capability`	✅	4s	3s	+33%
`unpack_hints`	✅	4s	6s	-33%
`unpack_pk`	✅	4s	5s	-20%
`keccak_f1600_x4_native_aarch64_v8a_scalar_hybrid`	✅	3s	4s	-25%
`keccak_f1600_x4_native_aarch64_v8a_v84a_scalar_hybrid`	✅	3s	1s	+200%
`keccakf1600_extract_bytes (big endian)`	✅	3s	2s	+50%
`keccakf1600x4_extract_bytes`	✅	3s	3s	+0%
`mld_ct_cmask_nonzero_u8`	✅	3s	4s	-25%
`mld_ct_get_optblocker_u32`	✅	3s	2s	+50%
`mld_prepare_domain_separation_prefix`	✅	3s	3s	+0%
`montgomery_reduce`	✅	3s	3s	+0%
`ntt_native_aarch64`	✅	3s	3s	+0%
`pack_pk`	✅	3s	3s	+0%
`poly_chknorm`	✅	3s	3s	+0%
`poly_chknorm_native`	✅	3s	2s	+50%
`poly_decompose`	✅	3s	4s	-25%
`poly_make_hint`	✅	3s	4s	-25%
`poly_ntt_native`	✅	3s	3s	+0%
`poly_permute_bitrev_to_custom_optional`	✅	3s	3s	+0%
`poly_pointwise_montgomery_native`	✅	3s	4s	-25%
`poly_uniform`	✅	3s	6s	-50%
`poly_uniform_eta`	✅	3s	4s	-25%
`poly_uniform_gamma1`	✅	3s	3s	+0%
`polyveck_pack_t0`	✅	3s	4s	-25%
`polyveck_unpack_t0`	✅	3s	3s	+0%
`polyvecl_pack_eta`	✅	3s	2s	+50%
`polyz_unpack`	✅	3s	1s	+200%
`polyz_unpack_c`	✅	3s	4s	-25%
`polyz_unpack_native`	✅	3s	4s	-25%
`power2round`	✅	3s	1s	+200%
`rej_eta_native`	✅	3s	4s	-25%
`shake128_release`	✅	3s	4s	-25%
`shake256_finalize`	✅	3s	1s	+200%
`shake256_squeeze`	✅	3s	2s	+50%
`unpack_sig`	✅	3s	2s	+50%
`use_hint`	✅	3s	4s	-25%
`keccak_f1600_x1_native_aarch64`	✅	2s	2s	+0%
`keccak_f1600_x1_native_aarch64_v84a`	✅	2s	4s	-50%
`keccak_finalize`	✅	2s	1s	+100%
`keccak_init`	✅	2s	2s	+0%
`mld_ct_abs_i32`	✅	2s	3s	-33%
`mld_ct_cmask_nonzero_u32`	✅	2s	3s	-33%
`mld_ct_get_optblocker_i64`	✅	2s	2s	+0%
`mld_ct_sel_int32`	✅	2s	4s	-50%
`mld_value_barrier_u32`	✅	2s	1s	+100%
`mld_value_barrier_u8`	✅	2s	1s	+100%
`pack_sig_c`	✅	2s	5s	-60%
`pack_sig_z`	✅	2s	3s	-33%
`pointwise_native_x86_64`	✅	2s	3s	-33%
`poly_caddq_native`	✅	2s	2s	+0%
`poly_chknorm_native_aarch64`	✅	2s	3s	-33%
`poly_decompose_native`	✅	2s	5s	-60%
`poly_invntt_tomont`	✅	2s	3s	-33%
`poly_invntt_tomont_native`	✅	2s	2s	+0%
`poly_permute_bitrev_to_custom_optional_native`	✅	2s	4s	-50%
`poly_reduce`	✅	2s	3s	-33%
`poly_use_hint_c`	✅	2s	2s	+0%
`polyveck_pack_eta`	✅	2s	2s	+0%
`polyvecl_unpack_z`	✅	2s	6s	-67%
`polyw1_pack`	✅	2s	2s	+0%
`rej_eta`	✅	2s	6s	-67%
`shake128_absorb`	✅	2s	2s	+0%
`shake128_init`	✅	2s	3s	-33%
`shake128_squeeze`	✅	2s	3s	-33%
`shake128x4_absorb_once`	✅	2s	2s	+0%
`shake256_absorb`	✅	2s	3s	-33%
`shake256_release`	✅	2s	2s	+0%
`keccakf1600x4_permute`	✅	1s	2s	-50%
`mld_ct_cmask_neg_i32`	✅	1s	3s	-67%
`mld_ct_get_optblocker_u8`	✅	1s	3s	-67%
`mld_value_barrier_i64`	✅	1s	2s	-50%
`shake256`	✅	1s	2s	-50%
`shake256x4_absorb_once`	✅	1s	2s	-50%
`shake256x4_squeezeblocks`	✅	1s	1s	+0%

oqs-bot · 2026-04-06T02:04:13Z

CBMC Results (ML-DSA-65)

Full Results (185 proofs)

Proof	Status	Current	Previous	Change
`TOTAL`	✅	2054s	2161s	-5.0%
`sign_verify_internal`	✅	237s	248s	-4%
`polyvecl_pointwise_acc_montgomery_c`	✅	221s	241s	-8%
`polyvec_matrix_expand_eager`	✅	174s	186s	-6%
`rej_uniform_native`	✅	124s	134s	-7%
`poly_pointwise_montgomery_c`	✅	107s	111s	-4%
`mld_invntt_layer`	✅	93s	100s	-7%
`mld_ct_memcmp`	✅	77s	79s	-3%
`mld_attempt_signature_generation`	✅	52s	52s	+0%
`mld_ntt_layer`	✅	40s	45s	-11%
`sign_keypair_internal`	✅	30s	33s	-9%
`sign_signature_internal`	✅	30s	30s	+0%
`fqmul`	✅	26s	32s	-19%
`polyvec_matrix_expand_eager_serial`	✅	26s	27s	-4%
`keccakf1600x4_permute_native`	✅	23s	23s	+0%
`sign_pk_from_sk`	✅	21s	21s	+0%
`polyt0_unpack`	✅	20s	20s	+0%
`rej_uniform`	✅	20s	20s	+0%
`poly_chknorm_c`	✅	17s	16s	+6%
`polyveck_power2round`	✅	15s	16s	-6%
`mld_ntt_butterfly_block`	✅	14s	16s	-12%
`polyveck_pointwise_poly_montgomery`	✅	14s	16s	-12%
`rej_uniform_c`	✅	14s	13s	+8%
`polyveck_add`	✅	13s	13s	+0%
`polyveck_decompose`	✅	13s	14s	-7%
`poly_uniform_eta_4x`	✅	12s	14s	-14%
`polyveck_use_hint`	✅	12s	8s	+50%
`poly_add`	✅	11s	13s	-15%
`poly_uniform_4x`	✅	11s	11s	+0%
`polyveck_invntt_tomont`	✅	11s	7s	+57%
`keccak_absorb_once_x4`	✅	10s	10s	+0%
`keccakf1600_permute_native`	✅	10s	7s	+43%
`mld_check_pct`	✅	10s	10s	+0%
`polyz_unpack_c`	✅	9s	8s	+12%
`keccak_absorb`	✅	8s	7s	+14%
`polyveck_caddq`	✅	8s	8s	+0%
`polyveck_ntt`	✅	8s	9s	-11%
`polyvecl_ntt`	✅	8s	7s	+14%
`sign`	✅	8s	9s	-11%
`keccakf1600_permute`	✅	7s	8s	-12%
`poly_invntt_tomont_c`	✅	7s	9s	-22%
`poly_shiftl`	✅	7s	4s	+75%
`polyvec_matrix_pointwise_montgomery_eager`	✅	7s	8s	-12%
`sign_open`	✅	7s	5s	+40%
`sign_signature_extmu`	✅	7s	2s	+250%
`keccakf1600_extract_bytes (big endian)`	✅	6s	4s	+50%
`pack_pk`	✅	6s	5s	+20%
`pack_sig_z`	✅	6s	1s	+500%
`pointwise_acc_native_aarch64`	✅	6s	6s	+0%
`pointwise_acc_native_x86_64`	✅	6s	5s	+20%
`poly_decompose_c`	✅	6s	4s	+50%
`poly_power2round`	✅	6s	6s	+0%
`polyveck_pack_eta`	✅	6s	2s	+200%
`polyveck_reduce`	✅	6s	6s	+0%
`polyveck_shiftl`	✅	6s	6s	+0%
`polyveck_sub`	✅	6s	7s	-14%
`mld_ct_cmask_nonzero_u32`	✅	5s	3s	+67%
`ntt_native_x86_64`	✅	5s	5s	+0%
`poly_caddq_c`	✅	5s	3s	+67%
`poly_chknorm_native_aarch64`	✅	5s	2s	+150%
`poly_uniform`	✅	5s	4s	+25%
`poly_uniform_gamma1_4x`	✅	5s	6s	-17%
`polyveck_unpack_t0`	✅	5s	5s	+0%
`power2round`	✅	5s	2s	+150%
`keccak_finalize`	✅	4s	2s	+100%
`keccak_squeezeblocks_x4`	✅	4s	6s	-33%
`mld_compute_pack_z`	✅	4s	8s	-50%
`mld_ct_abs_i32`	✅	4s	2s	+100%
`mld_h`	✅	4s	3s	+33%
`pack_sig_c`	✅	4s	2s	+100%
`pointwise_native_aarch64`	✅	4s	6s	-33%
`poly_caddq_native`	✅	4s	5s	-20%
`poly_chknorm_native`	✅	4s	2s	+100%
`poly_invntt_tomont`	✅	4s	4s	+0%
`poly_invntt_tomont_native`	✅	4s	3s	+33%
`poly_ntt_native`	✅	4s	3s	+33%
`poly_sub`	✅	4s	3s	+33%
`poly_uniform_eta`	✅	4s	4s	+0%
`polyeta_unpack`	✅	4s	5s	-20%
`polyt0_pack`	✅	4s	6s	-33%
`polyt1_unpack`	✅	4s	3s	+33%
`polyveck_pack_t0`	✅	4s	3s	+33%
`polyveck_unpack_eta`	✅	4s	3s	+33%
`polyvecl_pointwise_acc_montgomery_native`	✅	4s	3s	+33%
`polyvecl_uniform_gamma1`	✅	4s	4s	+0%
`polyvecl_uniform_gamma1_serial`	✅	4s	3s	+33%
`polyvecl_unpack_eta`	✅	4s	2s	+100%
`polyvecl_unpack_z`	✅	4s	3s	+33%
`polyw1_pack`	✅	4s	4s	+0%
`shake256_absorb`	✅	4s	2s	+100%
`shake256_squeeze`	✅	4s	3s	+33%
`sign_keypair`	✅	4s	4s	+0%
`sign_signature_pre_hash_internal`	✅	4s	4s	+0%
`sign_verify`	✅	4s	5s	-20%
`sign_verify_pre_hash_internal`	✅	4s	5s	-20%
`unpack_hints`	✅	4s	5s	-20%
`unpack_pk`	✅	4s	8s	-50%
`unpack_sk`	✅	4s	8s	-50%
`decompose`	✅	3s	2s	+50%
`fqscale`	✅	3s	4s	-25%
`intt_native_x86_64`	✅	3s	4s	-25%
`keccak_f1600_x1_native_aarch64`	✅	3s	1s	+200%
`keccak_f1600_x4_native_aarch64_v8a_scalar_hybrid`	✅	3s	3s	+0%
`keccakf1600x4_extract_bytes`	✅	3s	2s	+50%
`keccakf1600x4_xor_bytes`	✅	3s	3s	+0%
`make_hint`	✅	3s	2s	+50%
`mld_ct_cmask_neg_i32`	✅	3s	3s	+0%
`mld_ct_cmask_nonzero_u8`	✅	3s	2s	+50%
`mld_ct_get_optblocker_u32`	✅	3s	1s	+200%
`mld_ct_get_optblocker_u8`	✅	3s	2s	+50%
`mld_sample_s1_s2`	✅	3s	4s	-25%
`mld_sample_s1_s2_serial`	✅	3s	5s	-40%
`mld_value_barrier_i64`	✅	3s	2s	+50%
`montgomery_reduce`	✅	3s	3s	+0%
`ntt_native_aarch64`	✅	3s	3s	+0%
`pack_sk_rho_key_tr_s2_t0`	✅	3s	3s	+0%
`pack_sk_s1`	✅	3s	4s	-25%
`pointwise_native_x86_64`	✅	3s	4s	-25%
`poly_challenge`	✅	3s	7s	-57%
`poly_decompose_native`	✅	3s	3s	+0%
`poly_make_hint`	✅	3s	2s	+50%
`poly_ntt`	✅	3s	4s	-25%
`poly_permute_bitrev_to_custom_optional_native`	✅	3s	2s	+50%
`poly_pointwise_montgomery`	✅	3s	3s	+0%
`poly_pointwise_montgomery_native`	✅	3s	2s	+50%
`poly_uniform_gamma1`	✅	3s	4s	-25%
`poly_use_hint`	✅	3s	2s	+50%
`poly_use_hint_c`	✅	3s	3s	+0%
`polyeta_pack`	✅	3s	2s	+50%
`polyveck_chknorm`	✅	3s	4s	-25%
`polyveck_pack_w1`	✅	3s	3s	+0%
`polyvecl_chknorm`	✅	3s	4s	-25%
`polyvecl_pointwise_acc_montgomery`	✅	3s	5s	-40%
`polyz_unpack`	✅	3s	2s	+50%
`rej_eta_c`	✅	3s	4s	-25%
`rej_eta_native`	✅	3s	4s	-25%
`shake128_finalize`	✅	3s	2s	+50%
`shake128_release`	✅	3s	4s	-25%
`shake128x4_absorb_once`	✅	3s	3s	+0%
`shake256`	✅	3s	3s	+0%
`shake256_finalize`	✅	3s	1s	+200%
`shake256_init`	✅	3s	5s	-40%
`sign_signature`	✅	3s	5s	-40%
`sign_signature_pre_hash_shake256`	✅	3s	6s	-50%
`sign_verify_extmu`	✅	3s	3s	+0%
`sign_verify_pre_hash_shake256`	✅	3s	4s	-25%
`use_hint`	✅	3s	2s	+50%
`caddq`	✅	2s	2s	+0%
`keccak_f1600_x1_native_aarch64_v84a`	✅	2s	3s	-33%
`keccak_f1600_x4_native_aarch64_v8a_v84a_scalar_hybrid`	✅	2s	2s	+0%
`keccak_squeeze`	✅	2s	3s	-33%
`keccakf1600x4_permute`	✅	2s	2s	+0%
`mld_ct_get_optblocker_i64`	✅	2s	2s	+0%
`mld_keccakf1600_extract_bytes`	✅	2s	4s	-50%
`mld_prepare_domain_separation_prefix`	✅	2s	4s	-50%
`pack_sig_h_poly`	✅	2s	2s	+0%
`poly_caddq`	✅	2s	3s	-33%
`poly_caddq_native_aarch64`	✅	2s	4s	-50%
`poly_chknorm`	✅	2s	3s	-33%
`poly_decompose`	✅	2s	2s	+0%
`poly_ntt_c`	✅	2s	3s	-33%
`poly_permute_bitrev_to_custom_optional`	✅	2s	3s	-33%
`poly_reduce`	✅	2s	2s	+0%
`poly_use_hint_native`	✅	2s	5s	-60%
`polyt1_pack`	✅	2s	3s	-33%
`polyvecl_pack_eta`	✅	2s	4s	-50%
`polyz_unpack_native`	✅	2s	4s	-50%
`reduce32`	✅	2s	4s	-50%
`rej_eta`	✅	2s	2s	+0%
`shake128_absorb`	✅	2s	4s	-50%
`shake128_init`	✅	2s	2s	+0%
`shake128_squeeze`	✅	2s	1s	+100%
`sys_check_capability`	✅	2s	3s	-33%
`unpack_sig`	✅	2s	5s	-60%
`keccak_f1600_x4_native_aarch64_v84a`	✅	1s	1s	+0%
`keccak_init`	✅	1s	4s	-75%
`keccakf1600_xor_bytes`	✅	1s	2s	-50%
`keccakf1600_xor_bytes (big endian)`	✅	1s	2s	-50%
`mld_ct_sel_int32`	✅	1s	3s	-67%
`mld_value_barrier_u32`	✅	1s	3s	-67%
`mld_value_barrier_u8`	✅	1s	5s	-80%
`polyz_pack`	✅	1s	3s	-67%
`shake128x4_squeezeblocks`	✅	1s	4s	-75%
`shake256_release`	✅	1s	3s	-67%
`shake256x4_absorb_once`	✅	1s	4s	-75%
`shake256x4_squeezeblocks`	✅	1s	3s	-67%

jakemas · 2026-04-14T10:02:07Z

The format script excludes *.S from expand-tabs, so 13 HOL-Light proof assembly files still have tabs (the keccak and pointwise files under proofs/hol_light/{aarch64,x86_64}/mldsa/. Are these waiting on simpasm regeneration, or should they be included here?

mkannwischer · 2026-04-22T03:20:32Z

The format script excludes *.S from expand-tabs, so 13 HOL-Light proof assembly files still have tabs (the keccak and pointwise files under proofs/hol_light/{aarch64,x86_64}/mldsa/. Are these waiting on simpasm regeneration, or should they be included here?

Those files are generated by autogen/simpasm, so the exclusion of .S was not the cause - they just needed to be regenerated after rebase. However, since we have removed all tabs from .S files in dev/ as well, we might as well have it covered by format.

Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>

This commit ports pq-code-package/mlkem-native#1573. It replaces tabs by spaces in - All autogenerated asm via simpasm - All handwritten asm - All c/h source files It also extends the format and lint script to enforce the absense of tabs in source files. Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>

mkannwischer marked this pull request as ready for review April 6, 2026 04:01

mkannwischer requested a review from a team as a code owner April 6, 2026 04:01

mkannwischer assigned hanno-becker Apr 6, 2026

mkannwischer force-pushed the tabs branch from 1c3a469 to c22c554 Compare April 22, 2026 03:18

mkannwischer requested a review from hanno-becker April 22, 2026 03:20

hanno-becker approved these changes Apr 22, 2026

View reviewed changes

mkannwischer added 2 commits April 22, 2026 13:06

HOL-Light: Autogenerate AArch64 mldsa_ntt.S used by HOL-Light proof

4d4d7b4

Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>

mkannwischer force-pushed the tabs branch from c22c554 to 7eb2927 Compare April 22, 2026 05:06

mkannwischer merged commit 55c9fb6 into main Apr 22, 2026
425 checks passed

mkannwischer deleted the tabs branch April 22, 2026 08:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Port: Format: Don't allow tabs#1022

Port: Format: Don't allow tabs#1022
mkannwischer merged 2 commits intomainfrom
tabs

mkannwischer commented Apr 6, 2026

Uh oh!

oqs-bot commented Apr 6, 2026 •

edited

Loading

Uh oh!

oqs-bot commented Apr 6, 2026 •

edited

Loading

Uh oh!

oqs-bot commented Apr 6, 2026 •

edited

Loading

Uh oh!

jakemas commented Apr 14, 2026

Uh oh!

mkannwischer commented Apr 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

mkannwischer commented Apr 6, 2026

Uh oh!

oqs-bot commented Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CBMC Results (ML-DSA-44)

Uh oh!

oqs-bot commented Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CBMC Results (ML-DSA-87)

Uh oh!

oqs-bot commented Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CBMC Results (ML-DSA-65)

Uh oh!

jakemas commented Apr 14, 2026

Uh oh!

mkannwischer commented Apr 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

oqs-bot commented Apr 6, 2026 •

edited

Loading

oqs-bot commented Apr 6, 2026 •

edited

Loading

oqs-bot commented Apr 6, 2026 •

edited

Loading