Open
Conversation
da6eebe to
afc1cf6
Compare
Contributor
CBMC Results (ML-DSA-87)Full Results (173 proofs)
|
Contributor
CBMC Results (ML-DSA-44)Full Results (173 proofs)
|
Contributor
CBMC Results (ML-DSA-65)Full Results (173 proofs)
|
mkannwischer
requested changes
Jan 26, 2026
Contributor
mkannwischer
left a comment
There was a problem hiding this comment.
Thanks @willieyz.
You forgot to modify test_stack.c and test_rng_fail.c. In the files you changes you forgot a lot of functions.
test/acvp/acvp_mldsa.c
Outdated
Contributor
There was a problem hiding this comment.
Still using the SUPERCOP API.
test/bench/bench_mldsa.c
Outdated
Contributor
There was a problem hiding this comment.
still using the SUPERCOP API.
test/bench/bench_mldsa.c
Outdated
test/src/gen_KAT.c
Outdated
Contributor
There was a problem hiding this comment.
still using the SUPERCOP API
Contributor
There was a problem hiding this comment.
Using the SUPERCOP API in 25 places....
7880ef1 to
b4779ed
Compare
The SUPERCOP API (crypto_sign_*) is a compatibility layer intended for SUPERCOP benchmarking. Previously, the tests defined a series of SUPERCOP-style names for internal functions (the _internal variants), even though these tests are not part of the standard SUPERCOP API. Instead of defining SUPERCOP-related macros in every test source file, this commit updates all test files to include sign.h instead of directly including mldsa_native.h, allowing them to directly use the mld_sign_* functions defined in sign.h. It also adds MLD_CHECK_APIS in each test source files, ensuring that mldsa_native.h is still included during compilation. Signed-off-by: willieyz <willie.zhao@chelpis.com>
b4779ed to
50b94dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: Eliminate SUPERCOP API from tests #878
The SUPERCOP API (crypto_sign_*) is a compatibility layer intended for SUPERCOP benchmarking.
Previously, the tests defined a series of SUPERCOP-style names for internal functions (the _internal variants), even though these tests are not part of the standard SUPERCOP API.
Instead of defining SUPERCOP-related macros in every test source file, this commit updates those macros to target the regular mldsa-native API rather than the SUPERCOP compatibility layer.
As a result, the tests invoke the standard API directly while still using macros for name mapping.
Internal functions are now referenced via: