Mark all non-static declarations as internal or external by hanno-becker · Pull Request #951 · pq-code-package/mldsa-native

hanno-becker · 2026-02-05T14:08:12Z

This commit ensures that all non-static, non-assembly symbols declared by mldsa-native are explicitly marked as internal or external via the MLD_CONFIG_INTERNAL_API_QUALIFIER / MLD_CONFIG_EXTERNAL_API_QUALIFIER configuration options.

In particular, when mldsa-native is being built in a monobuild and MLD_CONFIG_INTERNAL_API_QUALIFIER set to static, only the FIPS204 API should be of external linkage.
If mldsa-native is being built in a monobuild, directly included into another compilation unit, and both MLD_CONFIG_INTERNAL_API_QUALIFIER and MLD_CONFIG_EXTERNAL_API_QUALIFIER set to static, no non-assembly symbols should be generated.

Resolves Ensure that all non-static symbols are guarded by MLD_CONFIG_{INTERNAL/EXTERNAL}_API_QUALIFIER #936

oqs-bot · 2026-02-06T06:33:41Z

CBMC Results (ML-DSA-44)

Full Results (174 proofs)

Proof	Status	Current	Previous	Change
`TOTAL`	✅	2031s	2088s	-2.7%
`mld_attempt_signature_generation`	✅	271s	213s	+27%
`polyvecl_pointwise_acc_montgomery_c`	✅	218s	208s	+5%
`sign_verify_internal`	✅	183s	249s	-27%
`poly_pointwise_montgomery_c`	✅	137s	140s	-2%
`rej_uniform_native`	✅	130s	130s	+0%
`mld_ct_memcmp`	✅	84s	84s	+0%
`mld_ntt_layer`	✅	60s	45s	+33%
`mld_invntt_layer`	✅	50s	116s	-57%
`keccak_squeezeblocks_x4`	✅	40s	43s	-7%
`sign_signature_internal`	✅	36s	44s	-18%
`polyvec_matrix_expand`	✅	28s	29s	-3%
`fqmul`	✅	21s	19s	+11%
`rej_uniform`	✅	20s	20s	+0%
`rej_uniform_c`	✅	19s	19s	+0%
`poly_chknorm_c`	✅	18s	17s	+6%
`poly_uniform_eta_4x`	✅	17s	15s	+13%
`polymat_permute_bitrev_to_custom`	✅	16s	15s	+7%
`mld_compute_t0_t1_tr_from_sk_components`	✅	15s	12s	+25%
`mld_ntt_butterfly_block`	✅	15s	11s	+36%
`poly_uniform_4x`	✅	15s	15s	+0%
`keccakf1600x4_permute_native`	✅	14s	12s	+17%
`polyeta_unpack`	✅	14s	12s	+17%
`polyz_unpack_c`	✅	14s	11s	+27%
`polyt0_unpack`	✅	13s	16s	-19%
`mld_compute_pack_z`	✅	11s	4s	+175%
`keccak_absorb_once_x4`	✅	10s	13s	-23%
`mld_polyvecl_permute_bitrev_to_custom_native`	✅	10s	12s	-17%
`keccakf1600_permute`	✅	9s	7s	+29%
`poly_invntt_tomont_c`	✅	9s	7s	+29%
`polyveck_add`	✅	8s	8s	+0%
`keccakf1600_permute_native`	✅	7s	9s	-22%
`poly_uniform_gamma1_4x`	✅	7s	4s	+75%
`polyveck_pointwise_poly_montgomery`	✅	7s	5s	+40%
`sign`	✅	7s	6s	+17%
`sign_pk_from_sk`	✅	7s	5s	+40%
`keccak_absorb`	✅	6s	6s	+0%
`mld_h`	✅	6s	5s	+20%
`poly_reduce`	✅	6s	2s	+200%
`poly_use_hint_c`	✅	6s	5s	+20%
`polyveck_chknorm`	✅	6s	5s	+20%
`polyveck_decompose`	✅	6s	7s	-14%
`polyveck_make_hint`	✅	6s	4s	+50%
`polyveck_reduce`	✅	6s	4s	+50%
`polyveck_sub`	✅	6s	5s	+20%
`rej_eta_c`	✅	6s	3s	+100%
`shake256_finalize`	✅	6s	5s	+20%
`sign_signature_extmu`	✅	6s	6s	+0%
`fqscale`	✅	5s	2s	+150%
`keccak_finalize`	✅	5s	3s	+67%
`keccak_squeeze`	✅	5s	2s	+150%
`keccakf1600x4_xor_bytes`	✅	5s	2s	+150%
`mld_ct_cmask_nonzero_u8`	✅	5s	4s	+25%
`mld_sample_s1_s2_serial`	✅	5s	3s	+67%
`pack_pk`	✅	5s	4s	+25%
`poly_add`	✅	5s	5s	+0%
`poly_caddq`	✅	5s	4s	+25%
`poly_chknorm_native`	✅	5s	4s	+25%
`poly_ntt_native`	✅	5s	4s	+25%
`poly_uniform_eta`	✅	5s	5s	+0%
`poly_use_hint_native`	✅	5s	4s	+25%
`polyt0_pack`	✅	5s	3s	+67%
`polyvec_matrix_expand_serial`	✅	5s	6s	-17%
`polyvec_matrix_pointwise_montgomery`	✅	5s	8s	-38%
`polyveck_power2round`	✅	5s	6s	-17%
`polyveck_shiftl`	✅	5s	5s	+0%
`polyveck_unpack_eta`	✅	5s	2s	+150%
`polyvecl_chknorm`	✅	5s	4s	+25%
`polyvecl_pack_eta`	✅	5s	4s	+25%
`polyvecl_pointwise_acc_montgomery_native`	✅	5s	2s	+150%
`rej_eta`	✅	5s	5s	+0%
`sign_keypair_internal`	✅	5s	8s	-38%
`unpack_hints`	✅	5s	6s	-17%
`keccakf1600x4_extract_bytes`	✅	4s	2s	+100%
`mld_check_pct`	✅	4s	10s	-60%
`mld_ct_get_optblocker_u32`	✅	4s	4s	+0%
`pack_sig_c_h`	✅	4s	3s	+33%
`pack_sk`	✅	4s	3s	+33%
`poly_caddq_native_aarch64`	✅	4s	3s	+33%
`poly_decompose_c`	✅	4s	4s	+0%
`poly_invntt_tomont`	✅	4s	5s	-20%
`poly_invntt_tomont_native`	✅	4s	4s	+0%
`poly_pointwise_montgomery_native`	✅	4s	4s	+0%
`poly_power2round`	✅	4s	2s	+100%
`polyt1_pack`	✅	4s	2s	+100%
`polyt1_unpack`	✅	4s	5s	-20%
`polyveck_caddq`	✅	4s	6s	-33%
`polyveck_invntt_tomont`	✅	4s	5s	-20%
`polyveck_ntt`	✅	4s	6s	-33%
`polyveck_use_hint`	✅	4s	3s	+33%
`polyvecl_ntt`	✅	4s	4s	+0%
`polyvecl_uniform_gamma1_serial`	✅	4s	4s	+0%
`polyvecl_unpack_eta`	✅	4s	2s	+100%
`rej_eta_native`	✅	4s	5s	-20%
`shake256_absorb`	✅	4s	2s	+100%
`sign_keypair`	✅	4s	4s	+0%
`sign_signature`	✅	4s	3s	+33%
`sign_signature_pre_hash_internal`	✅	4s	3s	+33%
`sign_verify`	✅	4s	3s	+33%
`sign_verify_pre_hash_shake256`	✅	4s	6s	-33%
`unpack_pk`	✅	4s	4s	+0%
`caddq`	✅	3s	5s	-40%
`decompose`	✅	3s	4s	-25%
`keccakf1600_xor_bytes`	✅	3s	4s	-25%
`make_hint`	✅	3s	3s	+0%
`mld_ct_abs_i32`	✅	3s	3s	+0%
`mld_ct_get_optblocker_i64`	✅	3s	2s	+50%
`mld_keccakf1600_extract_bytes`	✅	3s	3s	+0%
`mld_prepare_domain_separation_prefix`	✅	3s	5s	-40%
`mld_value_barrier_i64`	✅	3s	3s	+0%
`mld_value_barrier_u32`	✅	3s	2s	+50%
`pack_sig_z`	✅	3s	5s	-40%
`poly_caddq_native`	✅	3s	2s	+50%
`poly_challenge`	✅	3s	4s	-25%
`poly_chknorm`	✅	3s	2s	+50%
`poly_decompose`	✅	3s	3s	+0%
`poly_make_hint`	✅	3s	5s	-40%
`poly_ntt`	✅	3s	4s	-25%
`poly_ntt_c`	✅	3s	2s	+50%
`poly_uniform`	✅	3s	5s	-40%
`poly_uniform_gamma1`	✅	3s	3s	+0%
`poly_use_hint`	✅	3s	1s	+200%
`polyveck_pack_w1`	✅	3s	3s	+0%
`polyveck_unpack_t0`	✅	3s	3s	+0%
`polyvecl_pointwise_acc_montgomery`	✅	3s	3s	+0%
`polyvecl_unpack_z`	✅	3s	6s	-50%
`polyw1_pack`	✅	3s	4s	-25%
`polyz_pack`	✅	3s	3s	+0%
`polyz_unpack_native`	✅	3s	3s	+0%
`power2round`	✅	3s	2s	+50%
`shake128_init`	✅	3s	2s	+50%
`shake128_squeeze`	✅	3s	2s	+50%
`shake128x4_absorb_once`	✅	3s	4s	-25%
`shake256_release`	✅	3s	2s	+50%
`sign_signature_pre_hash_shake256`	✅	3s	5s	-40%
`sign_verify_extmu`	✅	3s	6s	-50%
`unpack_sig`	✅	3s	3s	+0%
`unpack_sk`	✅	3s	3s	+0%
`keccakf1600_extract_bytes (big endian)`	✅	2s	4s	-50%
`keccakf1600x4_permute`	✅	2s	2s	+0%
`mld_ct_cmask_neg_i32`	✅	2s	3s	-33%
`mld_ct_cmask_nonzero_u32`	✅	2s	3s	-33%
`mld_ct_get_optblocker_u8`	✅	2s	2s	+0%
`mld_ct_sel_int32`	✅	2s	3s	-33%
`mld_sample_s1_s2`	✅	2s	6s	-67%
`mld_value_barrier_u8`	✅	2s	3s	-33%
`montgomery_reduce`	✅	2s	2s	+0%
`ntt_native_x86_64`	✅	2s	2s	+0%
`poly_caddq_c`	✅	2s	2s	+0%
`poly_decompose_native`	✅	2s	5s	-60%
`poly_pointwise_montgomery`	✅	2s	4s	-50%
`poly_shiftl`	✅	2s	4s	-50%
`poly_sub`	✅	2s	2s	+0%
`polyeta_pack`	✅	2s	5s	-60%
`polyveck_pack_eta`	✅	2s	4s	-50%
`polyveck_pack_t0`	✅	2s	2s	+0%
`polyvecl_permute_bitrev_to_custom`	✅	2s	3s	-33%
`polyvecl_uniform_gamma1`	✅	2s	3s	-33%
`polyz_unpack`	✅	2s	2s	+0%
`reduce32`	✅	2s	2s	+0%
`shake128_finalize`	✅	2s	2s	+0%
`shake128_release`	✅	2s	2s	+0%
`shake128x4_squeezeblocks`	✅	2s	3s	-33%
`shake256`	✅	2s	2s	+0%
`shake256_init`	✅	2s	2s	+0%
`shake256_squeeze`	✅	2s	4s	-50%
`shake256x4_absorb_once`	✅	2s	3s	-33%
`shake256x4_squeezeblocks`	✅	2s	5s	-60%
`sign_open`	✅	2s	8s	-75%
`sign_verify_pre_hash_internal`	✅	2s	4s	-50%
`sys_check_capability`	✅	2s	3s	-33%
`use_hint`	✅	2s	3s	-33%
`keccak_init`	✅	1s	2s	-50%
`keccakf1600_xor_bytes (big endian)`	✅	1s	2s	-50%
`shake128_absorb`	✅	1s	3s	-67%

oqs-bot · 2026-02-06T06:33:54Z

CBMC Results (ML-DSA-87)

⚠️ Attention Required

Proof	Status	Current	Previous	Change
`mld_invntt_layer`	⚠️	116s	71s	+63%
`poly_invntt_tomont_c`	⚠️	45s	8s	+462%

Full Results (174 proofs)

Proof	Status	Current	Previous	Change
`TOTAL`	✅	2439s	2207s	+10.5%
`sign_verify_internal`	✅	301s	213s	+41%
`mld_attempt_signature_generation`	✅	226s	231s	-2%
`polyvecl_pointwise_acc_montgomery_c`	✅	175s	162s	+8%
`polyvec_matrix_expand`	✅	132s	128s	+3%
`poly_pointwise_montgomery_c`	✅	130s	130s	+0%
`rej_uniform_native`	✅	128s	120s	+7%
`mld_invntt_layer`	⚠️	116s	71s	+63%
`polyvec_matrix_expand_serial`	✅	103s	101s	+2%
`mld_ct_memcmp`	✅	81s	78s	+4%
`mld_ntt_layer`	✅	71s	49s	+45%
`poly_invntt_tomont_c`	⚠️	45s	8s	+462%
`sign_signature_internal`	✅	42s	40s	+5%
`keccak_squeezeblocks_x4`	✅	41s	44s	-7%
`mld_compute_t0_t1_tr_from_sk_components`	✅	27s	25s	+8%
`polymat_permute_bitrev_to_custom`	✅	24s	24s	+0%
`rej_uniform`	✅	19s	22s	-14%
`fqmul`	✅	18s	19s	-5%
`polyt0_unpack`	✅	17s	14s	+21%
`rej_uniform_c`	✅	16s	18s	-11%
`poly_chknorm_c`	✅	15s	17s	-12%
`poly_uniform_4x`	✅	15s	15s	+0%
`poly_uniform_eta_4x`	✅	15s	16s	-6%
`polyveck_add`	✅	15s	14s	+7%
`mld_ntt_butterfly_block`	✅	14s	11s	+27%
`polyeta_unpack`	✅	14s	13s	+8%
`polyveck_power2round`	✅	14s	15s	-7%
`keccakf1600x4_permute_native`	✅	13s	13s	+0%
`polyvec_matrix_pointwise_montgomery`	✅	12s	14s	-14%
`polyveck_reduce`	✅	10s	10s	+0%
`mld_polyvecl_permute_bitrev_to_custom_native`	✅	9s	9s	+0%
`poly_decompose_c`	✅	9s	7s	+29%
`polyveck_caddq`	✅	9s	8s	+12%
`keccak_absorb_once_x4`	✅	8s	12s	-33%
`mld_check_pct`	✅	8s	7s	+14%
`polyveck_chknorm`	✅	8s	6s	+33%
`sign`	✅	8s	8s	+0%
`sign_keypair_internal`	✅	8s	5s	+60%
`keccakf1600_permute`	✅	7s	9s	-22%
`keccakf1600_permute_native`	✅	7s	9s	-22%
`polyveck_decompose`	✅	7s	9s	-22%
`polyveck_invntt_tomont`	✅	7s	9s	-22%
`polyveck_ntt`	✅	7s	7s	+0%
`polyveck_pointwise_poly_montgomery`	✅	7s	6s	+17%
`polyvecl_ntt`	✅	7s	9s	-22%
`polyvecl_uniform_gamma1`	✅	7s	4s	+75%
`unpack_sk`	✅	7s	5s	+40%
`caddq`	✅	6s	4s	+50%
`mld_compute_pack_z`	✅	6s	6s	+0%
`mld_ct_get_optblocker_u8`	✅	6s	2s	+200%
`mld_sample_s1_s2`	✅	6s	8s	-25%
`mld_sample_s1_s2_serial`	✅	6s	6s	+0%
`polyveck_shiftl`	✅	6s	7s	-14%
`polyveck_unpack_t0`	✅	6s	4s	+50%
`polyveck_use_hint`	✅	6s	6s	+0%
`polyvecl_pointwise_acc_montgomery_native`	✅	6s	4s	+50%
`rej_eta_c`	✅	6s	5s	+20%
`sign_pk_from_sk`	✅	6s	9s	-33%
`sign_signature_pre_hash_shake256`	✅	6s	7s	-14%
`keccak_absorb`	✅	5s	4s	+25%
`mld_ct_cmask_nonzero_u8`	✅	5s	4s	+25%
`pack_sig_c_h`	✅	5s	2s	+150%
`poly_decompose_native`	✅	5s	4s	+25%
`poly_ntt`	✅	5s	2s	+150%
`poly_pointwise_montgomery`	✅	5s	2s	+150%
`poly_uniform`	✅	5s	3s	+67%
`poly_use_hint_c`	✅	5s	3s	+67%
`polyt0_pack`	✅	5s	4s	+25%
`polyt1_unpack`	✅	5s	5s	+0%
`polyveck_make_hint`	✅	5s	5s	+0%
`polyveck_sub`	✅	5s	7s	-29%
`polyvecl_pointwise_acc_montgomery`	✅	5s	2s	+150%
`polyvecl_uniform_gamma1_serial`	✅	5s	3s	+67%
`rej_eta_native`	✅	5s	3s	+67%
`sign_open`	✅	5s	4s	+25%
`sign_verify_extmu`	✅	5s	4s	+25%
`sys_check_capability`	✅	5s	3s	+67%
`unpack_hints`	✅	5s	5s	+0%
`keccak_finalize`	✅	4s	5s	-20%
`keccak_init`	✅	4s	2s	+100%
`keccakf1600_xor_bytes`	✅	4s	2s	+100%
`keccakf1600_xor_bytes (big endian)`	✅	4s	3s	+33%
`mld_ct_abs_i32`	✅	4s	2s	+100%
`mld_ct_get_optblocker_u32`	✅	4s	2s	+100%
`mld_ct_sel_int32`	✅	4s	1s	+300%
`mld_prepare_domain_separation_prefix`	✅	4s	5s	-20%
`mld_value_barrier_u32`	✅	4s	3s	+33%
`pack_sig_z`	✅	4s	3s	+33%
`poly_add`	✅	4s	5s	-20%
`poly_caddq`	✅	4s	3s	+33%
`poly_invntt_tomont`	✅	4s	5s	-20%
`poly_power2round`	✅	4s	5s	-20%
`poly_uniform_eta`	✅	4s	4s	+0%
`polyveck_pack_t0`	✅	4s	4s	+0%
`polyveck_pack_w1`	✅	4s	1s	+300%
`polyveck_unpack_eta`	✅	4s	7s	-43%
`polyvecl_chknorm`	✅	4s	4s	+0%
`polyvecl_unpack_z`	✅	4s	6s	-33%
`polyz_unpack_c`	✅	4s	6s	-33%
`power2round`	✅	4s	3s	+33%
`shake256_init`	✅	4s	2s	+100%
`shake256x4_absorb_once`	✅	4s	2s	+100%
`sign_keypair`	✅	4s	3s	+33%
`sign_signature`	✅	4s	4s	+0%
`sign_signature_extmu`	✅	4s	5s	-20%
`sign_signature_pre_hash_internal`	✅	4s	4s	+0%
`sign_verify_pre_hash_internal`	✅	4s	3s	+33%
`unpack_pk`	✅	4s	3s	+33%
`unpack_sig`	✅	4s	4s	+0%
`use_hint`	✅	4s	5s	-20%
`fqscale`	✅	3s	3s	+0%
`keccak_squeeze`	✅	3s	2s	+50%
`keccakf1600_extract_bytes (big endian)`	✅	3s	3s	+0%
`keccakf1600x4_extract_bytes`	✅	3s	5s	-40%
`keccakf1600x4_permute`	✅	3s	3s	+0%
`mld_value_barrier_u8`	✅	3s	2s	+50%
`montgomery_reduce`	✅	3s	4s	-25%
`ntt_native_x86_64`	✅	3s	3s	+0%
`poly_caddq_c`	✅	3s	5s	-40%
`poly_caddq_native_aarch64`	✅	3s	4s	-25%
`poly_challenge`	✅	3s	4s	-25%
`poly_chknorm`	✅	3s	5s	-40%
`poly_chknorm_native`	✅	3s	2s	+50%
`poly_decompose`	✅	3s	2s	+50%
`poly_ntt_c`	✅	3s	2s	+50%
`poly_pointwise_montgomery_native`	✅	3s	2s	+50%
`poly_shiftl`	✅	3s	2s	+50%
`poly_uniform_gamma1_4x`	✅	3s	5s	-40%
`poly_use_hint`	✅	3s	2s	+50%
`polyeta_pack`	✅	3s	4s	-25%
`polyveck_pack_eta`	✅	3s	2s	+50%
`polyvecl_pack_eta`	✅	3s	2s	+50%
`polyvecl_permute_bitrev_to_custom`	✅	3s	4s	-25%
`polyvecl_unpack_eta`	✅	3s	4s	-25%
`polyw1_pack`	✅	3s	3s	+0%
`polyz_unpack`	✅	3s	4s	-25%
`reduce32`	✅	3s	2s	+50%
`shake128_absorb`	✅	3s	2s	+50%
`shake128_finalize`	✅	3s	3s	+0%
`shake128_init`	✅	3s	5s	-40%
`shake128_squeeze`	✅	3s	2s	+50%
`shake128x4_squeezeblocks`	✅	3s	4s	-25%
`shake256`	✅	3s	4s	-25%
`shake256_release`	✅	3s	5s	-40%
`shake256x4_squeezeblocks`	✅	3s	2s	+50%
`sign_verify`	✅	3s	5s	-40%
`sign_verify_pre_hash_shake256`	✅	3s	4s	-25%
`decompose`	✅	2s	4s	-50%
`keccakf1600x4_xor_bytes`	✅	2s	3s	-33%
`make_hint`	✅	2s	3s	-33%
`mld_ct_cmask_nonzero_u32`	✅	2s	2s	+0%
`mld_ct_get_optblocker_i64`	✅	2s	1s	+100%
`mld_h`	✅	2s	6s	-67%
`mld_keccakf1600_extract_bytes`	✅	2s	2s	+0%
`mld_value_barrier_i64`	✅	2s	3s	-33%
`pack_pk`	✅	2s	2s	+0%
`pack_sk`	✅	2s	2s	+0%
`poly_caddq_native`	✅	2s	2s	+0%
`poly_invntt_tomont_native`	✅	2s	2s	+0%
`poly_make_hint`	✅	2s	3s	-33%
`poly_ntt_native`	✅	2s	3s	-33%
`poly_reduce`	✅	2s	3s	-33%
`poly_sub`	✅	2s	4s	-50%
`poly_uniform_gamma1`	✅	2s	2s	+0%
`poly_use_hint_native`	✅	2s	3s	-33%
`polyt1_pack`	✅	2s	2s	+0%
`polyz_pack`	✅	2s	3s	-33%
`polyz_unpack_native`	✅	2s	2s	+0%
`rej_eta`	✅	2s	2s	+0%
`shake128x4_absorb_once`	✅	2s	1s	+100%
`shake256_absorb`	✅	2s	1s	+100%
`shake256_finalize`	✅	2s	2s	+0%
`shake256_squeeze`	✅	2s	2s	+0%
`mld_ct_cmask_neg_i32`	✅	1s	2s	-50%
`shake128_release`	✅	1s	2s	-50%

oqs-bot · 2026-02-06T06:35:26Z

CBMC Results (ML-DSA-65)

⚠️ Attention Required

Proof	Status	Current	Previous	Change
`mld_invntt_layer`	⚠️	124s	72s	+72%
`poly_invntt_tomont_c`	⚠️	50s	9s	+456%

Full Results (174 proofs)

Proof	Status	Current	Previous	Change
`TOTAL`	✅	2391s	2319s	+3.1%
`polyvecl_pointwise_acc_montgomery_c`	✅	244s	229s	+7%
`sign_verify_internal`	✅	213s	357s	-40%
`mld_attempt_signature_generation`	✅	205s	202s	+1%
`poly_pointwise_montgomery_c`	✅	145s	136s	+7%
`rej_uniform_native`	✅	131s	130s	+1%
`mld_invntt_layer`	⚠️	124s	72s	+72%
`polyvec_matrix_expand`	✅	96s	93s	+3%
`mld_ct_memcmp`	✅	87s	79s	+10%
`mld_ntt_layer`	✅	74s	55s	+35%
`polyvec_matrix_expand_serial`	✅	67s	63s	+6%
`poly_invntt_tomont_c`	⚠️	50s	9s	+456%
`sign_signature_internal`	✅	47s	44s	+7%
`keccak_squeezeblocks_x4`	✅	43s	44s	-2%
`mld_compute_t0_t1_tr_from_sk_components`	✅	25s	24s	+4%
`poly_chknorm_c`	✅	22s	18s	+22%
`fqmul`	✅	20s	19s	+5%
`rej_uniform`	✅	20s	20s	+0%
`polymat_permute_bitrev_to_custom`	✅	19s	20s	-5%
`polyt0_unpack`	✅	19s	15s	+27%
`rej_uniform_c`	✅	19s	17s	+12%
`poly_uniform_eta_4x`	✅	18s	17s	+6%
`polyvec_matrix_pointwise_montgomery`	✅	18s	14s	+29%
`polyveck_decompose`	✅	16s	16s	+0%
`poly_uniform_4x`	✅	15s	18s	-17%
`mld_ntt_butterfly_block`	✅	14s	12s	+17%
`keccakf1600_permute_native`	✅	12s	7s	+71%
`keccakf1600x4_permute_native`	✅	12s	13s	-8%
`keccak_absorb_once_x4`	✅	11s	12s	-8%
`polyveck_ntt`	✅	11s	9s	+22%
`sign`	✅	11s	9s	+22%
`poly_decompose_c`	✅	10s	8s	+25%
`polyveck_invntt_tomont`	✅	10s	9s	+11%
`polyveck_reduce`	✅	10s	6s	+67%
`keccakf1600_permute`	✅	9s	7s	+29%
`mld_check_pct`	✅	9s	5s	+80%
`mld_polyvecl_permute_bitrev_to_custom_native`	✅	9s	10s	-10%
`polyveck_add`	✅	9s	10s	-10%
`polyeta_unpack`	✅	8s	5s	+60%
`polyveck_power2round`	✅	8s	10s	-20%
`polyvecl_ntt`	✅	8s	8s	+0%
`mld_h`	✅	7s	2s	+250%
`poly_pointwise_montgomery_native`	✅	7s	3s	+133%
`polyveck_caddq`	✅	7s	6s	+17%
`polyveck_pointwise_poly_montgomery`	✅	7s	4s	+75%
`polyveck_shiftl`	✅	7s	12s	-42%
`polyveck_sub`	✅	7s	9s	-22%
`polyveck_use_hint`	✅	7s	7s	+0%
`sign_signature_pre_hash_internal`	✅	7s	7s	+0%
`keccakf1600x4_xor_bytes`	✅	6s	1s	+500%
`mld_compute_pack_z`	✅	6s	6s	+0%
`poly_uniform`	✅	6s	4s	+50%
`poly_uniform_eta`	✅	6s	4s	+50%
`poly_use_hint_native`	✅	6s	3s	+100%
`polyt0_pack`	✅	6s	6s	+0%
`polyveck_make_hint`	✅	6s	3s	+100%
`shake128_init`	✅	6s	2s	+200%
`sign_pk_from_sk`	✅	6s	8s	-25%
`sign_signature`	✅	6s	5s	+20%
`decompose`	✅	5s	4s	+25%
`keccak_absorb`	✅	5s	5s	+0%
`keccak_squeeze`	✅	5s	3s	+67%
`mld_ct_get_optblocker_u32`	✅	5s	1s	+400%
`mld_sample_s1_s2`	✅	5s	5s	+0%
`ntt_native_x86_64`	✅	5s	3s	+67%
`poly_invntt_tomont`	✅	5s	2s	+150%
`poly_make_hint`	✅	5s	4s	+25%
`poly_reduce`	✅	5s	2s	+150%
`poly_uniform_gamma1_4x`	✅	5s	4s	+25%
`polyveck_pack_t0`	✅	5s	2s	+150%
`polyvecl_chknorm`	✅	5s	6s	-17%
`polyz_unpack_native`	✅	5s	2s	+150%
`rej_eta_native`	✅	5s	4s	+25%
`sign_open`	✅	5s	7s	-29%
`sign_signature_pre_hash_shake256`	✅	5s	4s	+25%
`sign_verify_extmu`	✅	5s	3s	+67%
`sys_check_capability`	✅	5s	4s	+25%
`unpack_hints`	✅	5s	6s	-17%
`unpack_sig`	✅	5s	3s	+67%
`unpack_sk`	✅	5s	3s	+67%
`keccak_finalize`	✅	4s	3s	+33%
`keccakf1600_xor_bytes (big endian)`	✅	4s	3s	+33%
`mld_sample_s1_s2_serial`	✅	4s	5s	-20%
`mld_value_barrier_i64`	✅	4s	1s	+300%
`montgomery_reduce`	✅	4s	3s	+33%
`poly_add`	✅	4s	4s	+0%
`poly_caddq`	✅	4s	3s	+33%
`poly_caddq_c`	✅	4s	4s	+0%
`poly_caddq_native`	✅	4s	4s	+0%
`poly_caddq_native_aarch64`	✅	4s	2s	+100%
`poly_invntt_tomont_native`	✅	4s	3s	+33%
`poly_uniform_gamma1`	✅	4s	3s	+33%
`poly_use_hint_c`	✅	4s	4s	+0%
`polyveck_chknorm`	✅	4s	6s	-33%
`polyveck_unpack_t0`	✅	4s	3s	+33%
`polyvecl_pointwise_acc_montgomery_native`	✅	4s	3s	+33%
`polyvecl_uniform_gamma1`	✅	4s	5s	-20%
`polyvecl_unpack_eta`	✅	4s	4s	+0%
`polyz_unpack_c`	✅	4s	5s	-20%
`rej_eta_c`	✅	4s	4s	+0%
`shake128x4_absorb_once`	✅	4s	3s	+33%
`shake256`	✅	4s	3s	+33%
`sign_keypair`	✅	4s	2s	+100%
`sign_keypair_internal`	✅	4s	5s	-20%
`sign_verify_pre_hash_internal`	✅	4s	2s	+100%
`use_hint`	✅	4s	3s	+33%
`fqscale`	✅	3s	3s	+0%
`keccak_init`	✅	3s	1s	+200%
`keccakf1600_extract_bytes (big endian)`	✅	3s	2s	+50%
`keccakf1600x4_extract_bytes`	✅	3s	2s	+50%
`keccakf1600x4_permute`	✅	3s	4s	-25%
`make_hint`	✅	3s	4s	-25%
`mld_ct_cmask_nonzero_u32`	✅	3s	3s	+0%
`mld_ct_cmask_nonzero_u8`	✅	3s	2s	+50%
`mld_prepare_domain_separation_prefix`	✅	3s	3s	+0%
`mld_value_barrier_u32`	✅	3s	4s	-25%
`pack_pk`	✅	3s	6s	-50%
`pack_sig_c_h`	✅	3s	1s	+200%
`pack_sk`	✅	3s	2s	+50%
`poly_challenge`	✅	3s	3s	+0%
`poly_chknorm_native`	✅	3s	5s	-40%
`poly_decompose`	✅	3s	4s	-25%
`poly_ntt_c`	✅	3s	5s	-40%
`poly_ntt_native`	✅	3s	2s	+50%
`poly_pointwise_montgomery`	✅	3s	5s	-40%
`poly_shiftl`	✅	3s	4s	-25%
`poly_use_hint`	✅	3s	2s	+50%
`polyveck_pack_eta`	✅	3s	3s	+0%
`polyveck_unpack_eta`	✅	3s	4s	-25%
`polyvecl_pack_eta`	✅	3s	4s	-25%
`polyvecl_uniform_gamma1_serial`	✅	3s	4s	-25%
`polyz_pack`	✅	3s	1s	+200%
`polyz_unpack`	✅	3s	3s	+0%
`shake128_absorb`	✅	3s	1s	+200%
`shake256_absorb`	✅	3s	1s	+200%
`shake256_init`	✅	3s	3s	+0%
`shake256_squeeze`	✅	3s	2s	+50%
`shake256x4_absorb_once`	✅	3s	3s	+0%
`sign_signature_extmu`	✅	3s	5s	-40%
`sign_verify`	✅	3s	3s	+0%
`sign_verify_pre_hash_shake256`	✅	3s	2s	+50%
`caddq`	✅	2s	3s	-33%
`keccakf1600_xor_bytes`	✅	2s	3s	-33%
`mld_ct_abs_i32`	✅	2s	2s	+0%
`mld_ct_cmask_neg_i32`	✅	2s	1s	+100%
`mld_ct_get_optblocker_u8`	✅	2s	3s	-33%
`mld_ct_sel_int32`	✅	2s	2s	+0%
`mld_keccakf1600_extract_bytes`	✅	2s	3s	-33%
`mld_value_barrier_u8`	✅	2s	3s	-33%
`poly_chknorm`	✅	2s	3s	-33%
`poly_decompose_native`	✅	2s	4s	-50%
`poly_ntt`	✅	2s	2s	+0%
`poly_power2round`	✅	2s	6s	-67%
`poly_sub`	✅	2s	5s	-60%
`polyt1_pack`	✅	2s	3s	-33%
`polyt1_unpack`	✅	2s	3s	-33%
`polyveck_pack_w1`	✅	2s	4s	-50%
`polyvecl_permute_bitrev_to_custom`	✅	2s	2s	+0%
`polyvecl_pointwise_acc_montgomery`	✅	2s	3s	-33%
`polyvecl_unpack_z`	✅	2s	3s	-33%
`polyw1_pack`	✅	2s	3s	-33%
`power2round`	✅	2s	4s	-50%
`reduce32`	✅	2s	3s	-33%
`rej_eta`	✅	2s	4s	-50%
`shake128_finalize`	✅	2s	1s	+100%
`shake128_release`	✅	2s	3s	-33%
`shake128_squeeze`	✅	2s	2s	+0%
`shake256_finalize`	✅	2s	4s	-50%
`shake256_release`	✅	2s	2s	+0%
`unpack_pk`	✅	2s	4s	-50%
`mld_ct_get_optblocker_i64`	✅	1s	3s	-67%
`pack_sig_z`	✅	1s	4s	-75%
`polyeta_pack`	✅	1s	3s	-67%
`shake128x4_squeezeblocks`	✅	1s	2s	-50%
`shake256x4_squeezeblocks`	✅	1s	3s	-67%

mkannwischer

Thanks @hanno-becker. The changes look good to me.
Strictly speaking you are not resolving #936 though.

This commit ensures that all non-static, non-assembly symbols declared by mldsa-native are explicitly marked as internal or external via the MLD_CONFIG_INTERNAL_API_QUALIFIER / MLD_CONFIG_EXTERNAL_API_QUALIFIER configuration options. In particular, when mldsa-native is being built in a monobuild and MLD_CONFIG_INTERNAL_API_QUALIFIER set to `static`, only the FIPS204 API should be of external linkage. If mldsa-native is being built in a monobuild, directly included into another compilation unit, and both MLD_CONFIG_INTERNAL_API_QUALIFIER and MLD_CONFIG_EXTERNAL_API_QUALIFIER set to `static`, no non-assembly symbols should be generated. Signed-off-by: Hanno Becker <beckphan@amazon.co.uk>

mkannwischer added the needs-mlkem-native-port label Feb 5, 2026

hanno-becker force-pushed the fix-api-qualifiers-936 branch from ea4a609 to 9470dbe Compare February 6, 2026 06:16

hanno-becker force-pushed the fix-api-qualifiers-936 branch 2 times, most recently from 5302946 to cd7a440 Compare February 6, 2026 08:58

hanno-becker marked this pull request as ready for review February 6, 2026 08:58

hanno-becker requested a review from a team as a code owner February 6, 2026 08:58

hanno-becker requested a review from mkannwischer February 6, 2026 09:30

mkannwischer approved these changes Feb 6, 2026

View reviewed changes

flynd mentioned this pull request Feb 6, 2026

Ensure that all non-static symbols are guarded by MLD_CONFIG_{INTERNAL/EXTERNAL}_API_QUALIFIER #936

Open

1 task

hanno-becker force-pushed the fix-api-qualifiers-936 branch from cd7a440 to 009f8a2 Compare February 6, 2026 20:28

hanno-becker marked this pull request as draft February 6, 2026 20:30

hanno-becker force-pushed the fix-api-qualifiers-936 branch from 009f8a2 to 038f696 Compare February 6, 2026 20:32

hanno-becker force-pushed the fix-api-qualifiers-936 branch from 038f696 to e45d93a Compare February 6, 2026 20:33

hanno-becker marked this pull request as ready for review February 6, 2026 20:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mark all non-static declarations as internal or external#951

Mark all non-static declarations as internal or external#951
hanno-becker wants to merge 1 commit intomainfrom
fix-api-qualifiers-936

hanno-becker commented Feb 5, 2026 •

edited

Loading

Uh oh!

oqs-bot commented Feb 6, 2026 •

edited

Loading

Uh oh!

oqs-bot commented Feb 6, 2026 •

edited

Loading

Uh oh!

oqs-bot commented Feb 6, 2026 •

edited

Loading

Uh oh!

mkannwischer left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

hanno-becker commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oqs-bot commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CBMC Results (ML-DSA-44)

Uh oh!

oqs-bot commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CBMC Results (ML-DSA-87)

Uh oh!

oqs-bot commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CBMC Results (ML-DSA-65)

Uh oh!

mkannwischer left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hanno-becker commented Feb 5, 2026 •

edited

Loading

oqs-bot commented Feb 6, 2026 •

edited

Loading

oqs-bot commented Feb 6, 2026 •

edited

Loading

oqs-bot commented Feb 6, 2026 •

edited

Loading