Skip to content

Cloudfront deployment#101

Open
djpragmaticcoders wants to merge 5 commits into
masterfrom
cloudfront-deployment
Open

Cloudfront deployment#101
djpragmaticcoders wants to merge 5 commits into
masterfrom
cloudfront-deployment

Conversation

@djpragmaticcoders
Copy link
Copy Markdown

No description provided.

Comment thread cloudfront/cloudfront.tf Outdated
] : a if a != ""]

enabled = true
price_class = "PriceClass_100"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zrobmy z tego parametr

Comment thread cloudfront/cloudfront.tf Outdated

restrictions {
geo_restriction {
restriction_type = "none"
Copy link
Copy Markdown

@arektomala arektomala Jul 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

potrzebne by to sparamentryzowac i dodac locations jako podzmienna do blokowania regionów

z terraforma powinno byc tak
restrictions {
geo_restriction {
restriction_type = "whitelist"
locations = ["US", "CA", "GB", "DE"]

Comment thread cloudfront/cloudfront.tf
geo_restriction {
restriction_type = "none"
restriction_type = var.restriction_type
locations = [var.locations]
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moze Ci sie wywalic, jezeli domyslnie restriction bedzie na none. Locations domyslnie chyba powinno byc na null w tkaim wypadku

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zmienilem, powinno byc ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants