Skip to content

Oracledb types temp - #2

Closed
prajalg wants to merge 17 commits into
masterfrom
oracledb-types-temp
Closed

Oracledb types temp#2
prajalg wants to merge 17 commits into
masterfrom
oracledb-types-temp

Conversation

@prajalg

@prajalg prajalg commented Jun 2, 2026

Copy link
Copy Markdown
Owner

Temp PR

Summary by CodeRabbit

  • New Features

    • Added TypeScript type definitions for Oracle Database 7.0, including support for end-user security contexts, direct path load operations, pipeline execution, and async disposal semantics on connections and pools.
  • Chores

    • Updated CI/CD workflows to support additional repository configuration.

@coderabbitai

coderabbitai Bot commented Jun 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 6fa507d5-9e1e-4953-a3c7-59e69edff672

📥 Commits

Reviewing files that changed from the base of the PR and between d367b05 and ac3fed0.

📒 Files selected for processing (11)
  • .github/workflows/CI.yml
  • .github/workflows/UpdateCodeowners.yml
  • .github/workflows/format-and-commit.yml
  • .github/workflows/ghostbuster.yml
  • .github/workflows/lint-md.yml
  • .github/workflows/pnpm-cache.yml
  • .github/workflows/support-window.yml
  • types/oracledb/index.d.ts
  • types/oracledb/oracledb-tests.ts
  • types/oracledb/package.json
  • types/oracledb/tsconfig.json

📝 Walkthrough

Walkthrough

This PR enables CI/CD workflows for a fork repository (prajalg/DefinitelyTyped) and introduces comprehensive TypeScript type definitions for Oracle Database 7.0, including new pipeline execution, security context, direct path load, async disposal, and tracing APIs.

Changes

CI/CD Workflow Fork Support

Layer / File(s) Summary
Repository condition updates across CI/CD workflows
.github/workflows/CI.yml, .github/workflows/UpdateCodeowners.yml, .github/workflows/format-and-commit.yml, .github/workflows/ghostbuster.yml, .github/workflows/lint-md.yml, .github/workflows/pnpm-cache.yml, .github/workflows/support-window.yml
All workflow if: conditions are expanded to include prajalg/DefinitelyTyped alongside DefinitelyTyped/DefinitelyTyped, enabling CI jobs for the fork repository across multiple workflows and job stages.

OracleDB 7.0 Type Definitions and Tests

Layer / File(s) Summary
Package and TypeScript configuration updates
types/oracledb/package.json, types/oracledb/tsconfig.json, types/oracledb/index.d.ts (lines 2)
Package version is bumped to 7.0 and TypeScript compiler configuration includes esnext.disposable library to support Symbol.asyncDispose functionality.
End-user security context types and configuration
types/oracledb/index.d.ts (lines 919–930, 1062–1132)
New global thickModeDSNPassthrough configuration option and EndUserSecurityContext class with related option types enable fine-grained end-user authentication control.
Connection identity and context management methods
types/oracledb/index.d.ts (lines 1237–1246, 1314–1322, 1402–1414, 1460–1481, 2223–2227)
Connection class gains new identity properties (dbUniqueName, pdbName) and methods for application context (appContext, clearAppContext) and end-user security context lifecycle management (clearEndUserSecurityContext), plus the supporting AppContextKeyValue type.
Connection async disposal and direct path load API
types/oracledb/index.d.ts (lines 1505–1512, 1548–1590)
Connection implements Symbol.asyncDispose for explicit resource management, and directPathLoad() enables bulk data insertion with typed column and data parameters.
Pipeline execution API and related types
types/oracledb/index.d.ts (lines 2628–2861, 1890–1973)
New Pipeline class with methods to add execute, executeMany, fetch, and commit operations, plus Connection.runPipeline() to execute pipelines with optional error continuation and setEndUserSecurityContext() to apply security contexts.
Async disposal for LOB, Pool, and ResultSet
types/oracledb/index.d.ts (lines 3184–3195, 3415–3422, 4468–4475)
LOB class gains trim() method for size reduction, and Pool/ResultSet classes implement Symbol.asyncDispose to support explicit async resource cleanup alongside Connection.
SQL utilities and trace handler enhancements
types/oracledb/index.d.ts (lines 5537–5591, 5861–5914)
New SQL string functions (enquoteLiteral, enquoteName, isQualifiedSqlName, isSimpleSqlName) for quoting and validation, plus TraceHandlerBase expands with pool lifecycle hooks (onPoolExpand, onPoolShrink, onPoolAcquire, onPoolRelease, onPoolWait, onPoolRequestTimeout, onPoolConnectionHit, onPoolConnectionMiss, onPoolClose).
Comprehensive test coverage for OracleDB 7.0 APIs
types/oracledb/oracledb-tests.ts (lines 914–1067)
New version7Tests function provides comprehensive type-checking coverage for SQL utilities, async disposal, trace handler inheritance, context configuration, directPathLoad with error handling, Lob.trim, and pipeline construction/execution in both promise and callback styles.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

🐰 A fork now runs with workflows bright,
OracleDB types reach version-height!
Pipelines flow and contexts secure,
Async disposal keeps resources pure—
Type-safety ✨ for databases sure!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Oracledb types temp' is vague and does not clearly convey the scope or nature of the changes; it uses generic language that fails to summarize the substantive work. Replace with a more descriptive title that reflects the main changes, such as 'Add OracleDB 7.0 TypeScript type definitions' or 'Update OracleDB types with v7.0 features and workflow configs'.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch oracledb-types-temp

Warning

Tools execution failed with the following error:

Failed to run tools: 13 INTERNAL: Received RST_STREAM with code 2 (Internal server error)


Comment @coderabbitai help to get the list of available commands and usage tips.

@prajalg prajalg closed this Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant