Chamlamh code reviews 2

[chamlamh]

Analysis of the program.
They have the foundation of the project. Firebase doesnt work, It give a unresolved error. Try to fix that for codereview but couldnt solve it.

Was the program available in UC Github on time? Yes

Is the program documented/commented well enough for you to understand? Yes

Does the program compile? Yes

The rationale behind your changes.

Did the simple change and try to make the firebase work for them because it was giving an error but I couldn't solve it myself.

Links to three specific commits that you made to your own group's GitHub repository before the end of sprint deadline.
If you do not post links to three commits that you made to your group's GitHub repo, your code review grade will be subject to a 20% penalty.
1: Jovial-Developer/IT3048CSpringProject@0248c94
2: Jovial-Developer/IT3048CSpringProject@8b722b9
3: Jovial-Developer/IT3048CSpringProject@61bb460

[discospiff]

Good to remove.
Avoid pushing commented code to Version Control. Version control has tools that makes this unnecessary.

• You can look at history to see what used to be there.
• You can use branches for experimental features.

[discospiff]

Are these used?

[discospiff]

From this review:

• Removing commented out code is a good idea.
• The IDE can format code automatically, and consistently, for all developers on the team. I'd use this instead of creating a branch, formatting manually, and then merging the branch.