Fix undo logic to prevent empty stack access#4
Open
rohith-adluri wants to merge 1 commit intoprateek27:mainfrom
Open
Fix undo logic to prevent empty stack access#4rohith-adluri wants to merge 1 commit intoprateek27:mainfrom
rohith-adluri wants to merge 1 commit intoprateek27:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue in the
undo()method of theCaretakerclass.Previously, the condition
!history.empty()allowedundo()to execute even when only one state was present. Afterpop(), this could result in callingpeek()on an empty stack, leading to a runtime exception.Changes
!history.empty()tohistory.size() > 1undo()peek()on empty stack)Why
The
undo()operation should only run when there is a valid previous state to restore. This change improves safety and prevents edge-case failures.