fix(responses): disable parallel tools on first inference - #711
Merged
leseb merged 4 commits intoAug 13, 2026
Merged
Conversation
Signed-off-by: Sumanth Kamenani <skamenan@redhat.com>
Signed-off-by: Sumanth Kamenani <skamenan@redhat.com>
skamenan7
marked this pull request as ready for review
August 13, 2026 13:09
Add a controlled synthetic scenario and recording that proves the agentic loop injects `parallel_tool_calls: false` into the upstream request when the client omits it. This closes the inference fixture coverage gap for the dirty-marker implementation. - Add `agentic-loop-fixture.yaml` example config (replay-safe subset of the agentic loop pipeline without external callout filters) - Add `agentic_loop` and `iterative_request_router` to the replay filter allowlist (they make no external callouts) - Add scenario, recording, and coverage.yaml entry for `responses.agentic.parallel_tool_calls` - Update the snapshot test in `coverage.rs` for the new scope, feature, scenario, and recording counts - Regenerate example and inference READMEs Signed-off-by: Sébastien Han <seb@redhat.com>
leseb
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Forces the agentic loop's first provider request to send
parallel_tool_calls:falsewhen the client omits the field or explicitly sendstrue. Provider-visible request mutations now mark the Responses state for outbound serialization, while an already-false request keeps byte-exact passthrough.agentic_loopmarks changed provider-visible fields as requiring a request-body rebuild.openai_responses_proxyrebuilds only when the explicit request-body state requires it.true, and byte-exact explicitfalsebehavior.Related issue
Closes #677
Validation
make lintValidation run:
cargo test -p praxis-ai-apis agentic_loop(46 passed)cargo test -p praxis-tests-integration --test suite examples::agentic_loop(6 passed)make testpraxis-aiserver with the agentic-loop example configuration and a controlled local inference backend. The captured provider-bound requests show omitted and explicittruereaching first inference asfalse; explicitfalseretained the same request-body length and SHA-256 across the proxy.Checklist
Signed-off-bytrailer.Breaking changes
None.