feat(compact): complete remaining issue #30 items - #726
Draft
crstrn13 wants to merge 2 commits into
Draft
Conversation
- Use previous_usage total_tokens before falling back to tiktoken
- Add configurable summary_prefix (default: "[Previous conversation summary]\n\n")
- Persist compaction as a separate response record in the store
- Hide compaction items from GET /v1/responses/{id}/input_items
- Handle explicit POST /v1/responses/compact endpoint
Closes praxis-proxy#30
Signed-off-by: Alexander Cristurean <acristur@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes the remaining work items from #30:
previous_usagefor token estimation —should_compact()checks the storedusage.total_tokensfrom the rehydrated response before falling back to local tiktoken countingsummary_prefixconfig option (default:[Previous conversation summary]) carried through to compaction items and both translation pathsinput_itemsAPI —normalize_input_items()filters out{"type": "compaction"}items so clients never see internal statePOST /v1/responses/{id}/compacttriggers compaction on a previously stored responseTest plan
cargo test -p praxis-ai-apis— new unit tests for all 5 itemscargo test -p praxis-ai-filters— no regressions in filter testsmake lintpasses