Skip to content

Fixed bug with global dir using unicode characters #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mark-mon wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed bug with global dir using unicode characters #398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Framework.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1002,7 +1002,8 @@ void Framework::save_config() {
mod->on_config_save(cfg);
}

if (!cfg.save(get_persistent_dir("config.txt").string())) {
auto path_u8 = get_persistent_dir("config.txt").u8string();
if (!cfg.save(std::string(path_u8.begin(), path_u8.end()))) {
spdlog::info("Failed to save config");
return;
}
Expand Down
3 changes: 2 additions & 1 deletion src/Mods.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,8 @@ std::optional<std::string> Mods::on_initialize_d3d_thread() const {
}

void Mods::reload_config(bool set_defaults) const {
utility::Config cfg{ Framework::get_persistent_dir("config.txt").string() };
auto path_u8 = Framework::get_persistent_dir("config.txt").u8string();
utility::Config cfg{ std::string(path_u8.begin(), path_u8.end()) };

for (auto& mod : m_mods) {
spdlog::info("{:s}::on_config_load()", mod->get_name().data());
Expand Down