Modal vector test01#3
Open
prayush wants to merge 2 commits into
Open
Conversation
9fb759a to
652cd92
Compare
Codecov Report
@@ Coverage Diff @@
## develop #3 +/- ##
=========================================
Coverage ? 98.8%
=========================================
Files ? 316
Lines ? 11351
Branches ? 0
=========================================
Hits ? 11215
Misses ? 136
Partials ? 0
Continue to review full report at Codecov.
|
2fbdea5 to
0600ff3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Types of changes:
Component:
Code review checklist
double* pd_blahis badtests/Unit/TestingFramework.hpp(only in tests)noexceptspecification for functions (if unsure, marknoexcept)constwhenever possibleauto, except with expression templates, i.e.DataVectorfixup. These commits are flaggedby Travis so we do not accidentally merge them.
2.or2.0over2Tensor's non-member get if the indices are constant expressions, e.g.get<1>(tensor)Further comments