Skip to content

Modal vector test02#4

Open
prayush wants to merge 4 commits into
developfrom
modalVector_test02
Open

Modal vector test02#4
prayush wants to merge 4 commits into
developfrom
modalVector_test02

Conversation

@prayush

@prayush prayush commented Jun 4, 2018

Copy link
Copy Markdown
Owner

Proposed changes

Types of changes:

  • Bugfix
  • New feature

Component:

  • Code
  • Documentation
  • Build system
  • Continuous integration

Code review checklist

  • Follows code review guidelines
  • Code has documentation and unit tests
  • Private member variables have a trailing underscore
  • Do not use Hungarian notation, e.g. double* pd_blah is bad
  • Header order:
    1. hpp corresponding to cpp (only in cpp files) or tests/Unit/TestingFramework.hpp (only in tests)
    2. Blank line (only in cpp files and tests)
    3. STL and externals (in alphabetical order)
    4. Blank line
    5. SpECTRE includes (in alphabetical order)
  • File lists in CMake are alphabetical
  • Correct noexcept specification for functions (if unsure, mark noexcept)
  • Mark objects const whenever possible
  • Almost always auto, except with expression templates, i.e. DataVector
  • All commits for performance changes provide quantitative evidence and the tests used to obtain said evidence.
  • Make sure error messages are helpful, e.g. "The number of grid points in the matrix 'F' is not the same as the number of grid points in the determinant."
  • Prefix commits addressing PR requests with fixup. These commits are flagged
    by Travis so we do not accidentally merge them.
  • Include what you use, prefer forward declarations in hpp files.
  • Explicitly make numbers floating point, e.g. 2. or 2.0 over 2
  • Use Tensor's non-member get if the indices are constant expressions, e.g.
    get<1>(tensor)

Further comments

@codecov-io

codecov-io commented Jun 4, 2018

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (develop@e966cc7). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop       #4   +/-   ##
==========================================
  Coverage           ?   98.74%           
==========================================
  Files              ?      294           
  Lines              ?    10831           
  Branches           ?        0           
==========================================
  Hits               ?    10695           
  Misses             ?      136           
  Partials           ?        0
Impacted Files Coverage Δ
src/DataStructures/ModalVector.hpp 100% <100%> (ø)
src/DataStructures/ModalVector.cpp 100% <100%> (ø)
src/Utilities/StdHelpers.hpp 98.11% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e966cc7...a8968d8. Read the comment docs.

@prayush prayush force-pushed the modalVector_test02 branch from a8968d8 to d26c602 Compare July 1, 2018 23:32
@prayush prayush force-pushed the develop branch 3 times, most recently from 2fbdea5 to 0600ff3 Compare May 15, 2019 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants