Skip to content

Add ModalVector LocalPR#6

Open
prayush wants to merge 6 commits into
developfrom
coefficientVector
Open

Add ModalVector LocalPR#6
prayush wants to merge 6 commits into
developfrom
coefficientVector

Conversation

@prayush

@prayush prayush commented Jul 27, 2018

Copy link
Copy Markdown
Owner

Proposed changes

Types of changes:

  • Bugfix
  • New feature

Component:

  • Code
  • Documentation
  • Build system
  • Continuous integration

Code review checklist

  • The PR passes all checks, including unit tests, clang-tidy and IWYU. For
    instructions on how to perform the CI checks locally refer to the Dev guide
    on the Travis CI
    .
  • The code is documented and the documentation renders correctly. Run make doc
    to generate the documentation locally into BUILD_DIR/docs/html. Then open
    index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.

Further comments

@codecov-io

codecov-io commented Jul 27, 2018

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (develop@bb9a347). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop       #6   +/-   ##
==========================================
  Coverage           ?   98.82%           
==========================================
  Files              ?      336           
  Lines              ?    12047           
  Branches           ?        0           
==========================================
  Hits               ?    11905           
  Misses             ?      142           
  Partials           ?        0
Impacted Files Coverage Δ
src/DataStructures/ModalVector.hpp 100% <100%> (ø)
src/DataStructures/ModalVector.cpp 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb9a347...4d52ab4. Read the comment docs.

@prayush prayush force-pushed the develop branch 3 times, most recently from 2fbdea5 to 0600ff3 Compare May 15, 2019 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants