GH-591 fix sw being loaded from CDN#1328
Open
kencanak wants to merge 6 commits intopreactjs:masterfrom
Open
Conversation
… cdn issue - introduced new cli args to define swPath, default would be '/' - decoupled from using webpack public path, better to be implicit
Member
|
I am still thinking if adding one more flag is the right thing to do here or can we handle it differently |
prateekbh
requested changes
Jul 27, 2020
Member
prateekbh
left a comment
prateekbh
left a comment
There was a problem hiding this comment.
I dont think this needs a new flag.
cc: @developit
Member
|
Can't this just always use |
Member
|
I guess people would sometimes like to build the app for a subfolder? like |
added 2 commits
July 30, 2020 11:29
… of __webpack_public_path__ if it begins with http protocol, set it blank
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug Fix, this will close #591
process.env.SW_PATHinstead of webpack public path/Did you add tests for your changes?
N/A, did a local test though
Summary
Service Worker loaded from CDN, see #591 for more details
Does this PR introduce a breaking change?
don't think so