Skip to content

Suim Bid Adapter : initial release#13045

Merged
ChrisHuie merged 3 commits into
prebid:masterfrom
suim-ad:add-suim-adapter
May 20, 2025
Merged

Suim Bid Adapter : initial release#13045
ChrisHuie merged 3 commits into
prebid:masterfrom
suim-ad:add-suim-adapter

Conversation

@rororo
Copy link
Copy Markdown
Contributor

@rororo rororo commented Apr 29, 2025 •
edited
Loading

Type of change

  • New bidder adapter

Description of change

New bidder adapter for suim.

  • contact email of the adapter’s maintainer: prebid@suimad.com
  • test parameters for validating bids:
bidder: 'suim',
params: {
    ad_space_id: '01hw085aphq9qdtnwgdnm5q5b8'
}

Other information

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 29, 2025

Tread carefully! This PR adds 12 linter errors and 1 linter warning (possibly disabled through directives):

  • modules/suimBidAdapter.js (+12 errors, +1 warning)

@rororo rororo force-pushed the add-suim-adapter branch from 162883d to 49aacc8 Compare April 30, 2025 07:34
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 30, 2025

Tread carefully! This PR adds 1 linter warning (possibly disabled through directives):

  • modules/suimBidAdapter.js (+1 warning)

@rororo rororo marked this pull request as ready for review April 30, 2025 08:18
patmmccann
patmmccann reviewed Apr 30, 2025
View reviewed changes
Comment thread modules/suimBidAdapter.js Outdated
Copy link
Copy Markdown
Collaborator

@patmmccann patmmccann Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we recommend text/plain

Copy link
Copy Markdown
Contributor Author

@rororo rororo May 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks!

@ChrisHuie ChrisHuie changed the title New adapter: suim Suim Bid Adapter : initial release May 8, 2025
@ChrisHuie
Copy link
Copy Markdown
Collaborator

ChrisHuie commented May 8, 2025

@rororo can you please add docs to our docs repo for this new adapter -> https://github.com/prebid/prebid.github.io

@rororo rororo force-pushed the add-suim-adapter branch from 58c0058 to 5f4d6bc Compare May 9, 2025 06:04
@rororo
Copy link
Copy Markdown
Contributor Author

rororo commented May 9, 2025

Rebased branch

@rororo rororo mentioned this pull request May 15, 2025
Merged
3 tasks
@rororo
Copy link
Copy Markdown
Contributor Author

rororo commented May 15, 2025

@rororo can you please add docs to our docs repo for this new adapter -> https://github.com/prebid/prebid.github.io

@ChrisHuie

Sorry for missing that. I’ve created the document.
prebid/prebid.github.io#6040

@ChrisHuie ChrisHuie self-assigned this May 20, 2025
@ChrisHuie ChrisHuie merged commit 53d3c3a into prebid:master May 20, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patmmccann patmmccann patmmccann left review comments

@ChrisHuie ChrisHuie ChrisHuie approved these changes

Assignees

@ChrisHuie ChrisHuie

Labels

feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rororo @ChrisHuie @patmmccann